Rename XML model serialization helper method from Write to WriteXml#9750
Merged
jorgerangel-msft merged 3 commits intomainfrom Feb 20, 2026
Merged
Rename XML model serialization helper method from Write to WriteXml#9750jorgerangel-msft merged 3 commits intomainfrom
Write to WriteXml#9750jorgerangel-msft merged 3 commits intomainfrom
Conversation
…perties Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>
...onTypeDefinitions/TestData/XmlSerializationTests/XmlSerializationForDiscriminatedBaseType.cs
Show resolved
Hide resolved
Copilot
AI
changed the title
[WIP] Rename Write method in XML model serialization
Rename XML model serialization helper method from Feb 19, 2026
Write to WriteXml
…ivate XML helper to WriteXml Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>
jorgerangel-msft
approved these changes
Feb 19, 2026
JoshLove-msft
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The private
Write(XmlWriter, ModelReaderWriterOptions, string)helper method in XML model serialization collides with model properties namedWrite(e.g., Azure Storage'sBlobAnalyticsLogging.Write), causing compile errors in generated code.Changes
XmlWriteMethodNameconstant changed from"Write"to"WriteXml"inMrwSerializationTypeDefinition.Xml.csMockMrwProviderandFilteredMethodsTypeProviderlambdas inXmlSerializationTests.csupdated to match both"WriteXml"(private helper) and"Write"(theIPersistableModel<T>.Writeexplicit interface method)WriteXml; theIPersistableModel<T>.Writeexplicit interface method is preserved unchangedBefore / After
Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.