virt_mshv_vtl: Share common processing between poll_apic implementations #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smalis-msft
commented
Jan 8, 2025
smalis-msft
commented
Jan 8, 2025
smalis-msft
force-pushed
the
share-apic-poll
branch
from
9b7b8e6 to
9e6782e
Compare
smalis-msft
changed the title
smalis-msft
force-pushed
the
share-apic-poll
branch
from
9e6782e to
c318e45
Compare
smalis-msft
changed the title
jstarks
reviewed
Jan 28, 2025
jstarks
reviewed
Jan 28, 2025
jstarks
previously approved these changes
Jan 29, 2025
jstarks
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pulls out the common ordering and processing needed for poll_apic across TDX and SNP. While there are similarities between this code and the poll_apic implementation in mshv, this PR does not change anything in mshv, as the lapic emulation code there is going to be deleted soon. This also allows this code to live off of HardwareIsolatedBacking, making it much cleaner than the first iteration.
Also cleanup SNP's weird register conversions.