Add a todo

smalis-msft · web-flow · commit f496f580d961 · 2025-01-29T10:54:52.000-08:00
diff --git a/openhcl/virt_mshv_vtl/src/processor/tdx/mod.rs b/openhcl/virt_mshv_vtl/src/processor/tdx/mod.rs
@@ -1166,6 +1166,7 @@ impl<'b> hardware_cvm::apic::ApicBacking<'b, TdxBacked> for TdxApicScanner<'_, '
 
     fn handle_nmi(&mut self, vtl: GuestVtl) -> Result<(), UhRunVpError> {
         // Exit idle when an interrupt is received, regardless of IF
+        // TODO: Investigate lifting more activity management into poll_apic_core
         if self.vp.backing.cvm.lapics[vtl].activity == MpState::Idle {
             self.vp.backing.cvm.lapics[vtl].activity = MpState::Running;
         }

Original file line number	Diff line number	Diff line change
`@@ -1166,6 +1166,7 @@ impl<'b> hardware_cvm::apic::ApicBacking<'b, TdxBacked> for TdxApicScanner<'_, '`
`1166`	`1166`
`1167`	`1167`	`fn handle_nmi(&mut self, vtl: GuestVtl) -> Result<(), UhRunVpError> {`
`1168`	`1168`	`// Exit idle when an interrupt is received, regardless of IF`
	`1169`	`+ // TODO: Investigate lifting more activity management into poll_apic_core`
`1169`	`1170`	`if self.vp.backing.cvm.lapics[vtl].activity == MpState::Idle {`
`1170`	`1171`	`self.vp.backing.cvm.lapics[vtl].activity = MpState::Running;`
`1171`	`1172`	`}`