New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image Customizer - Support modifying Verity protected base image. #83

Merged

liulanze merged 9 commits into main from user/lanzeliu/modifying-verity-protection

Jan 27, 2025

Contributor

liulanze commented Jan 13, 2025 •

edited

Loading

Checklist

Tests added/updated
Documentation updated (if needed)
Code conforms to style guidelines

liulanze requested a review from a team as a code owner

January 13, 2025 17:11

cwize1 requested changes

View reviewed changes

toolkit/tools/imagecustomizerapi/extendedmountidentifiertype.go Outdated Show resolved Hide resolved

toolkit/tools/internal/file/file.go Outdated Show resolved Hide resolved

toolkit/tools/pkg/imagecustomizerlib/partitionutils.go Show resolved Hide resolved

toolkit/tools/pkg/imagecustomizerlib/partitionutils.go Outdated Show resolved Hide resolved

toolkit/tools/pkg/imagecustomizerlib/partitionutils.go Outdated Show resolved Hide resolved

toolkit/tools/pkg/imagecustomizerlib/partitionutils.go Outdated Show resolved Hide resolved

jiria reviewed

View reviewed changes

toolkit/tools/internal/file/file.go Outdated Show resolved Hide resolved

toolkit/tools/pkg/imagecustomizerlib/dracututils.go Show resolved Hide resolved

toolkit/tools/pkg/imagecustomizerlib/partitionutils.go Outdated Show resolved Hide resolved

toolkit/tools/pkg/imagecustomizerlib/partitionutils.go Outdated Show resolved Hide resolved

toolkit/tools/pkg/imagecustomizerlib/partitionutils.go Outdated Show resolved Hide resolved

toolkit/tools/pkg/imagecustomizerlib/partitionutils.go Show resolved Hide resolved

toolkit/tools/pkg/imagecustomizerlib/partitionutils.go Outdated Show resolved Hide resolved

toolkit/tools/pkg/imagecustomizerlib/partitionutils.go Outdated Show resolved Hide resolved

gmileka reviewed

View reviewed changes

toolkit/tools/pkg/imagecustomizerlib/partitionutils.go Outdated Show resolved Hide resolved

gmileka reviewed

View reviewed changes

toolkit/tools/pkg/imagecustomizerlib/partitionutils.go Show resolved Hide resolved

gmileka reviewed

View reviewed changes

toolkit/tools/pkg/imagecustomizerlib/partitionutils.go Outdated Show resolved Hide resolved

gmileka reviewed

View reviewed changes

toolkit/tools/pkg/imagecustomizerlib/partitionutils.go Outdated Show resolved Hide resolved

gmileka reviewed

View reviewed changes

toolkit/tools/pkg/imagecustomizerlib/partitionutils.go Outdated Show resolved Hide resolved

fintelia reviewed

View reviewed changes

toolkit/tools/pkg/imagecustomizerlib/partitionutils.go Outdated Show resolved Hide resolved

gmileka reviewed

View reviewed changes

toolkit/tools/pkg/imagecustomizerlib/partitionutils.go Outdated Show resolved Hide resolved

gmileka reviewed

View reviewed changes

toolkit/tools/pkg/imagecustomizerlib/partitionutils.go Outdated Show resolved Hide resolved

cwize1 mentioned this pull request

Add Phase 2 COSI Support #85

Merged

3 tasks

cwize1 requested changes

View reviewed changes

toolkit/tools/pkg/imagecustomizerlib/customizeverity.go Outdated Show resolved Hide resolved

toolkit/tools/pkg/imagecustomizerlib/extendedmountidentifiertype.go Outdated Show resolved Hide resolved

toolkit/tools/pkg/imagecustomizerlib/imagecustomizer.go Show resolved Hide resolved

toolkit/tools/pkg/imagecustomizerlib/partitionutils.go Outdated Show resolved Hide resolved

liulanze commented

View reviewed changes

toolkit/tools/pkg/imagecustomizerlib/customizeverity.go Outdated Show resolved Hide resolved

toolkit/tools/pkg/imagecustomizerlib/imagecustomizer.go Show resolved Hide resolved

toolkit/tools/pkg/imagecustomizerlib/extendedmountidentifiertype.go Outdated Show resolved Hide resolved

toolkit/tools/pkg/imagecustomizerlib/partitionutils.go Outdated Show resolved Hide resolved

toolkit/tools/pkg/imagecustomizerlib/partitionutils.go Outdated Show resolved Hide resolved

toolkit/tools/pkg/imagecustomizerlib/partitionutils.go Outdated Show resolved Hide resolved

toolkit/tools/pkg/imagecustomizerlib/partitionutils.go Outdated Show resolved Hide resolved

toolkit/tools/pkg/imagecustomizerlib/partitionutils.go Show resolved Hide resolved

toolkit/tools/pkg/imagecustomizerlib/partitionutils.go Outdated Show resolved Hide resolved

cwize1 requested changes

View reviewed changes

toolkit/tools/pkg/imagecustomizerlib/imagecustomizer.go Outdated Show resolved Hide resolved

toolkit/tools/pkg/imagecustomizerlib/partitionutils.go Show resolved Hide resolved

toolkit/tools/pkg/imagecustomizerlib/partitionutils.go Outdated Show resolved Hide resolved

toolkit/tools/pkg/imagecustomizerlib/partitionutils.go Outdated Show resolved Hide resolved

cwize1 requested changes

View reviewed changes

toolkit/tools/pkg/imagecustomizerlib/imagecustomizer.go Outdated Show resolved Hide resolved

toolkit/tools/pkg/imagecustomizerlib/imagecustomizer.go Outdated Show resolved Hide resolved

toolkit/tools/pkg/imagecustomizerlib/partitionutils.go Outdated Show resolved Hide resolved

toolkit/tools/pkg/imagecustomizerlib/partitionutils.go Outdated Show resolved Hide resolved

toolkit/tools/pkg/imagecustomizerlib/partitionutils.go Outdated Show resolved Hide resolved

toolkit/tools/pkg/imagecustomizerlib/partitionutils.go Outdated Show resolved Hide resolved

toolkit/tools/pkg/imagecustomizerlib/partitionutils.go Outdated Show resolved Hide resolved

toolkit/tools/pkg/imagecustomizerlib/partitionutils.go Outdated Show resolved Hide resolved

toolkit/tools/pkg/imagecustomizerlib/partitionutils.go Outdated Show resolved Hide resolved

toolkit/tools/pkg/imagecustomizerlib/partitionutils.go Show resolved Hide resolved

cwize1 reviewed

View reviewed changes

toolkit/tools/pkg/imagecustomizerlib/imagecustomizer.go Outdated Show resolved Hide resolved

liulanze force-pushed the user/lanzeliu/modifying-verity-protection branch from db2b848 to b288d4a Compare

January 26, 2025 21:39

liulanze requested review from cwize1, jiria, fintelia and gmileka

January 27, 2025 04:16

cwize1 requested changes

View reviewed changes

toolkit/tools/pkg/imagecustomizerlib/imagecustomizer.go Outdated Show resolved Hide resolved

toolkit/tools/pkg/imagecustomizerlib/imagecustomizer.go Show resolved Hide resolved

toolkit/tools/pkg/imagecustomizerlib/partitionutils.go Outdated Show resolved Hide resolved

toolkit/tools/pkg/imagecustomizerlib/partitionutils.go Show resolved Hide resolved

toolkit/tools/pkg/imagecustomizerlib/partitionutils.go Outdated Show resolved Hide resolved

toolkit/tools/pkg/imagecustomizerlib/partitionutils.go Show resolved Hide resolved

liulanze requested a review from cwize1

January 27, 2025 23:10

cwize1 approved these changes

View reviewed changes

liulanze added 5 commits

January 27, 2025 15:53


          Prism supports modifying Verity protected base image.

cd1e12a


          Revision addressing 1st round comments.

9e6db24


          Address comments 2nd round.

81a03d3


          Address comments.


          Address comments.

fad8e0b

liulanze added 4 commits

January 27, 2025 15:53


          Address comments before working on internal funcs.

00cb609


          Addressed comments before working on internal func replacement.

d1a0a8b


          Address internal functions comments.

b095715


          Addressed comment

3fda754

liulanze force-pushed the user/lanzeliu/modifying-verity-protection branch from 41a1c45 to 3fda754 Compare

January 27, 2025 23:54

liulanze merged commit 2c820c2 into main

7 checks passed

liulanze deleted the user/lanzeliu/modifying-verity-protection branch

January 27, 2025 23:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet