-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Phase 2 COSI Support #85
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fintelia
reviewed
Jan 14, 2025
frhuelsz
reviewed
Jan 15, 2025
cwize1
requested changes
Jan 16, 2025
cwize1
requested changes
Jan 17, 2025
cwize1
requested changes
Jan 22, 2025
cwize1
reviewed
Jan 23, 2025
cwize1
requested changes
Jan 23, 2025
cwize1
requested changes
Jan 23, 2025
cwize1
approved these changes
Jan 23, 2025
bcdd5c4
to
19c9008
Compare
19c9008
to
73469b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary:
This is a phase 2 COSI support, we should now be able to generate cosi file from a non-verity base image with a verity config, and the verity information will be included in the cosi metadata file, so it will align with expected sample format
local test:

tested with command
sudo ./imagecustomizer --log-level debug --build-dir ./build --image-file core-3.0.20241220.vhdx --output-image-file ./output-image-test.cosi --output-image-format cosi --config-file ../pkg/imagecustomizerlib/testdata/verity-config.yaml
unpacked the .cosi file
and obtained output/metadata.json
Note:
A verity base image currently is not supported, will wait customizations on verity images to be enabled. Also, will have a follow-up pr to fix the missing mountpoints.
Checklist