Skip to content

.NET: Fix sample README paths that point to missing directories - #9581

Draft
Naveen Chatlapalli (1aifanatic) wants to merge 1 commit into
microsoft:mainfrom
1aifanatic:contrib/dotnet-sample-readme-paths
Draft

Naveen Chatlapalli (1aifanatic) wants to merge 1 commit into
microsoft:mainfrom
1aifanatic:contrib/dotnet-sample-readme-paths

Conversation

@1aifanatic

Copy link
Copy Markdown
Contributor

Motivation & Context

Two .NET sample READMEs tell readers to cd into directories that do not exist:

  • dotnet/samples/02-agents/AgentOpenTelemetry/README.md (Step 3, "Run the Console Application") uses cd dotnet/demos/AgentOpenTelemetry. There is no dotnet/demos directory anymore; the sample lives at dotnet/samples/02-agents/AgentOpenTelemetry.
  • dotnet/samples/02-agents/ModelContextProtocol/README.md gives cd Agents_Step01_Running as its example. No such directory exists under ModelContextProtocol.

Description & Review Guide

  • What are the major changes?
    • AgentOpenTelemetry: cd dotnet/demos/AgentOpenTelemetry → cd dotnet/samples/02-agents/AgentOpenTelemetry.
    • ModelContextProtocol: cd Agents_Step01_Running → cd Agent_MCP_Server. That is the first sample in the README's table, and it reads exactly the AZURE_OPENAI_ENDPOINT / AZURE_OPENAI_DEPLOYMENT_NAME variables the README sets in the next step.
  • What is the impact of these changes? Documentation only. The commands now resolve to real sample directories.
  • What do you want reviewers to focus on? Nothing beyond confirming the paths.

I found these by checking every cd / --project path in the repo's README code blocks against the tree. This PR does not overlap with #8492, which edits a different section (lines 47–53) of the AgentOpenTelemetry README.

Related Issue

N/A - trivial change: each command points to a directory that does not exist, and the correct directory is unambiguous, so the desired result is not in dispute.

AI Assistance

  • No material AI assistance was used.
  • This is an AI-assisted contribution. I reviewed, understood, and verified all submitted content and accept responsibility for it.

AI assistance details: Claude Code helped write the script that found the broken paths, make the edits, and draft this description.

Contribution Checklist

  • The code builds clean without any errors or warnings
  • All unit tests pass, and I have added new tests where possible
  • The PR follows the Contribution Guidelines
  • This PR links to an agreed issue with no competing open PR, or the Related Issue section documents a trivial-change or repository-automation exception.
  • This is not a breaking change. If it is a breaking change, add the breaking change label (or add "[BREAKING]" to the title prefix, before or after any language prefix) — a workflow keeps the label and title prefix in sync automatically.

🤖 Generated with Claude Code

The AgentOpenTelemetry README told readers to cd into
dotnet/demos/AgentOpenTelemetry, but the sample now lives under
dotnet/samples/02-agents. The ModelContextProtocol README used
Agents_Step01_Running as its example directory, which does not exist
there; Agent_MCP_Server is the sample that uses the environment
variables the README sets next.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Both corrected paths match the intended sample directories, with no unresolved issues.

No open issues 🎉

What changed in this PR

Corrects two directory paths in .NET sample README commands. Documentation only; runtime behavior is unchanged.

Changes:

  • Points OpenTelemetry instructions to the current sample directory.
  • Uses Agent_MCP_Server as the Model Context Protocol example.
File Description
dotnet/​samples/​02-agents/​ModelContextProtocol/​README.md Replaces the missing example directory with Agent_MCP_Server.
dotnet/​samples/​02-agents/​AgentOpenTelemetry/​README.md Updates the command to use the current samples/02-agents path.

Review effort: Balanced

@agent-framework-automation agent-framework-automation Bot added documentation Usage: [Issues, PRs], Target: documentation in the code base and learn docs .NET Usage: [Issues, PRs], Target: .Net labels Oct 21, 2026

This branch was successfully deployed

1 active deployment
github-app-auth — 622fdea7 Deployed Oct 21, 2026 by 1aifanatic via team_check #7165
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Usage: [Issues, PRs], Target: documentation in the code base and learn docs .NET Usage: [Issues, PRs], Target: .Net

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants