Fix double error on invalid delete of readonly property #55449

shinichy · 2023-08-21T14:19:04Z

Fixes #53082. This PR added a unit test based on #53961.

shinichy · 2023-08-21T15:48:58Z

@microsoft-github-policy-service agree

jakebailey · 2023-08-21T17:44:24Z

@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot user test tsserver
@typescript-bot test tsserver top100
@typescript-bot run dt
@typescript-bot perf test this
@typescript-bot pack this

typescript-bot · 2023-08-21T17:44:27Z

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at 43590df. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-08-21T17:44:27Z

Heya @jakebailey, I've started to run the tarball bundle task on this PR at 43590df. You can monitor the build here.

typescript-bot · 2023-08-21T17:44:27Z

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at 43590df. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-08-21T17:44:27Z

Heya @jakebailey, I've started to run the diff-based user code test suite (tsserver) on this PR at 43590df. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-08-21T17:44:27Z

Heya @jakebailey, I've started to run the regular perf test suite on this PR at 43590df. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-08-21T17:44:27Z

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at 43590df. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-08-21T17:44:27Z

Heya @jakebailey, I've started to run the diff-based top-repos suite (tsserver) on this PR at 43590df. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-08-21T17:46:41Z

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/156751/artifacts?artifactName=tgz&fileId=9AA462E5F3F96A2FEC2B26B1A0AAC53F049DE420193ECC00029DE74F602DD0CA02&fileName=/typescript-5.3.0-insiders.20230821.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/[email protected]".;

src/compiler/checker.ts

typescript-bot · 2023-08-21T18:00:06Z

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/55449/merge:

Everything looks good!

typescript-bot · 2023-08-21T18:03:55Z

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/55449/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Unknown failure"
2 instances of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

rxjs-src

/mnt/ts_downloads/rxjs-src/build.sh

[NEW] error TS2428: All declarations of 'WeakMap' must have identical type parameters.
- /home/vsts/work/1/s/typescript-55449/lib/lib.es2015.collection.d.ts(62,11)
- /home/vsts/work/1/s/typescript-55449/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-55449/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-55449/lib/lib.es2015.collection.d.ts(62,11)
- /home/vsts/work/1/s/typescript-55449/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-55449/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-55449/lib/lib.es2015.collection.d.ts(62,11)
- /home/vsts/work/1/s/typescript-55449/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-55449/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-55449/lib/lib.es2015.collection.d.ts(62,11)
- /home/vsts/work/1/s/typescript-55449/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-55449/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-55449/lib/lib.es2015.collection.d.ts(62,11)
- /home/vsts/work/1/s/typescript-55449/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-55449/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
[MISSING] error TS2428: All declarations of 'WeakMap' must have identical type parameters.
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(62,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(62,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(62,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(62,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(62,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)

typescript-bot · 2023-08-21T18:15:59Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{300,363k (± 0.00%)}	_{300,358k (± 0.01%)}	_~	_300,341k	_300,392k	_{p=0.260 n=6}
_{Parse Time}	_{3.02s (± 0.17%)}	_{3.02s (± 0.28%)}	_~	_3.00s	_3.02s	_{p=0.070 n=6}
_{Bind Time}	_{0.93s (± 0.00%)}	_{0.93s (± 0.00%)}	_~	_0.93s	_0.93s	_{p=1.000 n=6}
_{Check Time}	_{9.49s (± 0.30%)}	_{9.49s (± 0.36%)}	_~	_9.44s	_9.52s	_{p=0.870 n=6}
_{Emit Time}	_{7.63s (± 0.34%)}	_{7.64s (± 0.43%)}	_~	_7.59s	_7.68s	_{p=0.366 n=6}
_{Total Time}	_{21.08s (± 0.19%)}	_{21.08s (± 0.29%)}	_~	_20.97s	_21.14s	_{p=1.000 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{193,886k (± 0.01%)}	_{193,871k (± 0.02%)}	_~	_193,827k	_193,926k	_{p=0.378 n=6}
_{Parse Time}	_{1.57s (± 1.30%)}	_{1.56s (± 0.99%)}	_~	_1.55s	_1.58s	_{p=0.417 n=6}
_{Bind Time}	_{0.79s (± 0.00%)}	_{0.79s (± 0.00%)}	_~	_0.79s	_0.79s	_{p=1.000 n=6}
_{Check Time}	_{9.94s (± 0.23%)}	_{9.94s (± 0.34%)}	_~	_9.91s	_10.00s	_{p=0.627 n=6}
_{Emit Time}	_{2.74s (± 0.15%)}	_{2.74s (± 0.27%)}	_~	_2.73s	_2.75s	_{p=0.389 n=6}
_{Total Time}	_{15.04s (± 0.14%)}	_{15.03s (± 0.23%)}	_~	_14.99s	_15.08s	_{p=0.808 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{347,125k (± 0.00%)}	_{347,129k (± 0.00%)}	_~	_347,124k	_347,147k	_{p=0.421 n=6}
_{Parse Time}	_{2.69s (± 0.33%)}	_{2.68s (± 0.30%)}	_~	_2.67s	_2.69s	_{p=0.270 n=6}
_{Bind Time}	_{0.99s (± 0.00%)}	_{0.99s (± 0.00%)}	_~	_0.99s	_0.99s	_{p=1.000 n=6}
_{Check Time}	_{7.92s (± 0.25%)}	_{7.94s (± 0.28%)}	_~	_7.91s	_7.97s	_{p=0.252 n=6}
_{Emit Time}	_{4.25s (± 0.41%)}	_{4.27s (± 0.43%)}	_~	_4.24s	_4.29s	_{p=0.247 n=6}
_{Total Time}	_{15.85s (± 0.17%)}	_{15.88s (± 0.19%)}	_~	_15.84s	_15.92s	_{p=0.144 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{301,137k (± 0.00%)}	_{301,144k (± 0.01%)}	_~	_301,111k	_301,157k	_{p=0.149 n=6}
_{Parse Time}	_{2.18s (± 0.41%)}	_{2.18s (± 0.58%)}	_~	_2.16s	_2.20s	_{p=1.000 n=6}
_{Bind Time}	_{1.11s (± 0.37%)}	_{1.11s (± 0.37%)}	_~	_1.10s	_1.11s	_{p=0.218 n=6}
_{Check Time}	_{7.24s (± 0.38%)}	_{7.24s (± 0.23%)}	_~	_7.21s	_7.25s	_{p=1.000 n=6}
_{Emit Time}	_{3.96s (± 0.26%)}	_{3.97s (± 0.82%)}	_~	_3.92s	_4.01s	_{p=0.360 n=6}
_{Total Time}	_{14.48s (± 0.26%)}	_{14.50s (± 0.18%)}	_~	_14.45s	_14.53s	_{p=0.419 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{479,480k (± 0.01%)}	_{479,475k (± 0.01%)}	_~	_479,423k	_479,536k	_{p=0.936 n=6}
_{Parse Time}	_{3.15s (± 0.20%)}	_{3.15s (± 0.17%)}	_~	_3.15s	_3.16s	_{p=0.201 n=6}
_{Bind Time}	_{0.91s (± 0.00%)}	_{0.91s (± 0.00%)}	_~	_0.91s	_0.91s	_{p=1.000 n=6}
_{Check Time}	_{17.99s (± 0.40%)}	_{17.92s (± 0.42%)}	_~	_17.83s	_18.01s	_{p=0.226 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.04s (± 0.32%)}	_{21.99s (± 0.35%)}	_~	_21.89s	_22.08s	_{p=0.296 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{542,845k (± 0.01%)}	_{542,826k (± 0.02%)}	_~	_542,766k	_542,988k	_{p=0.298 n=6}
_{Parse Time}	_{3.70s (± 0.30%)}	_{3.70s (± 0.22%)}	_~	_3.68s	_3.70s	_{p=1.000 n=6}
_{Bind Time}	_{1.38s (± 4.31%)}	_{1.38s (± 4.31%)}	_~	_1.34s	_1.46s	_{p=1.000 n=6}
_{Check Time}	_{3.29s (± 2.59%)}	_{3.29s (± 2.51%)}	_~	_3.18s	_3.37s	_{p=0.871 n=6}
_{Emit Time}	_{0.08s (± 0.00%)}	_{0.08s (± 4.99%)}	_~	_0.08s	_0.09s	_{p=0.405 n=6}
_{Total Time}	_{8.46s (± 0.31%)}	_{8.45s (± 0.32%)}	_~	_8.41s	_8.49s	_{p=0.572 n=6}

System info unknown

Hosts

node (v16.17.1, x64)

Scenarios

Angular - node (v16.17.1, x64)
Compiler-Unions - node (v16.17.1, x64)
Monaco - node (v16.17.1, x64)
TFS - node (v16.17.1, x64)
material-ui - node (v16.17.1, x64)
xstate - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,492ms (± 0.23%)}	_{2,489ms (± 0.11%)}	_~	_2,484ms	_2,491ms	_{p=0.574 n=6}
_{Req 2 - geterr}	_{5,960ms (± 0.40%)}	_{5,947ms (± 0.36%)}	_~	_5,924ms	_5,984ms	_{p=0.378 n=6}
_{Req 3 - references}	_{344ms (± 1.35%)}	_{344ms (± 0.49%)}	_~	_342ms	_346ms	_{p=0.366 n=6}
_{Req 4 - navto}	_{279ms (± 1.01%)}	_{277ms (± 0.27%)}	_~	_276ms	_278ms	_{p=0.453 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{82ms (± 7.63%)}	_{87ms (± 6.73%)}	_~	_81ms	_93ms	_{p=0.145 n=6}
_{CompilerTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,629ms (± 1.09%)}	_{2,620ms (± 0.74%)}	_~	_2,591ms	_2,642ms	_{p=0.810 n=6}
_{Req 2 - geterr}	_{4,752ms (± 0.15%)}	_{4,743ms (± 0.30%)}	_~	_4,723ms	_4,765ms	_{p=0.173 n=6}
_{Req 3 - references}	_{350ms (± 0.12%)}	_{350ms (± 0.23%)}	_~	_350ms	_352ms	_{p=0.218 n=6}
_{Req 4 - navto}	_{269ms (± 0.19%)}	_{269ms (± 0.15%)}	_~	_269ms	_270ms	_{p=0.595 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{79ms (± 0.00%)}	_{79ms (± 0.52%)}	_~	_78ms	_79ms	_{p=0.405 n=6}
_{xstateTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,714ms (± 0.09%)}	_{2,716ms (± 0.15%)}	_~	_2,711ms	_2,721ms	_{p=0.171 n=6}
_{Req 2 - geterr}	_{1,934ms (± 1.91%)}	_{1,940ms (± 1.04%)}	_~	_1,900ms	_1,952ms	_{p=0.334 n=6}
_{Req 3 - references}	_{135ms (± 7.87%)}	_{137ms (± 2.95%)}	_~	_132ms	_142ms	_{p=0.625 n=6}
_{Req 4 - navto}	_{353ms (± 0.43%)}	_{353ms (± 0.43%)}	_~	_352ms	_355ms	_{p=0.410 n=6}
_{Req 5 - completionInfo count}	_{2,071 (± 0.00%)}	_{2,071 (± 0.00%)}	_~	_2,071	_2,071	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{319ms (± 2.42%)}	_{322ms (± 2.44%)}	_~	_314ms	_332ms	_{p=0.573 n=6}

System info unknown

Hosts

node (v16.17.1, x64)

Scenarios

CompilerTSServer - node (v16.17.1, x64)
Compiler-UnionsTSServer - node (v16.17.1, x64)
xstateTSServer - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v16.17.1, x64)}
_{Execution time}	_{155.63ms (± 0.20%)}	_{155.43ms (± 0.15%)}	_{-0.20ms (- 0.13%)}	_154.49ms	_158.44ms	_{p=0.000 n=600}
_{tsserver-startup - node (v16.17.1, x64)}
_{Execution time}	_{230.95ms (± 0.13%)}	_{230.76ms (± 0.13%)}	_{-0.19ms (- 0.08%)}	_229.63ms	_235.56ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v16.17.1, x64)}
_{Execution time}	_{234.90ms (± 0.11%)}	_{236.07ms (± 0.15%)}	_{+1.17ms (+ 0.50%)}	_234.63ms	_242.34ms	_{p=0.000 n=600}
_{typescript-startup - node (v16.17.1, x64)}
_{Execution time}	_{235.87ms (± 0.15%)}	_{235.77ms (± 0.12%)}	_{-0.10ms (- 0.04%)}	_234.23ms	_240.54ms	_{p=0.004 n=600}

System info unknown

Hosts

node (v16.17.1, x64)

Scenarios

tsc-startup - node (v16.17.1, x64)
tsserver-startup - node (v16.17.1, x64)
tsserverlibrary-startup - node (v16.17.1, x64)
typescript-startup - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2023-08-21T18:39:09Z

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/55449/merge:

Everything looks good!

typescript-bot · 2023-08-21T19:45:00Z

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/55449/merge:

Everything looks good!

typescript-bot · 2023-08-21T19:59:10Z

Hey @jakebailey, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

)

Fix double error on invalid delete of readonly property

17d023b

typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Aug 21, 2023

dprint fmt

43590df

jakebailey reviewed Aug 21, 2023

View reviewed changes

src/compiler/checker.ts Show resolved Hide resolved

shinichy requested a review from jakebailey August 22, 2023 05:40

shinichy added 2 commits August 23, 2023 21:44

Add a compiler test

ae90b41

revert src/testRunner/unittests/tsserver/inconsistentErrorInEditor.ts

d39288c

jakebailey approved these changes Aug 24, 2023

View reviewed changes

jakebailey merged commit 98d7e0b into microsoft:main Aug 24, 2023

shinichy deleted the 53082_double_error_on_delete branch August 25, 2023 03:41

jakebailey mentioned this pull request Sep 15, 2023

Fix double error on invalid delete of readonly property #53961

Closed

snovader pushed a commit to EG-A-S/TypeScript that referenced this pull request Sep 23, 2023

Fix double error on invalid delete of readonly property (microsoft#55449

f3abfc4

)

Fix double error on invalid delete of readonly property #55449

Fix double error on invalid delete of readonly property #55449

Uh oh!

Conversation

shinichy commented Aug 21, 2023

Uh oh!

shinichy commented Aug 21, 2023

Uh oh!

jakebailey commented Aug 21, 2023

Uh oh!

typescript-bot commented Aug 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Aug 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Aug 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Aug 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Aug 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Aug 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Aug 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Aug 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

typescript-bot commented Aug 21, 2023

Uh oh!

typescript-bot commented Aug 21, 2023

rxjs-src

/mnt/ts_downloads/rxjs-src/build.sh

Uh oh!

typescript-bot commented Aug 21, 2023

Compiler

tsserver

Startup

Uh oh!

typescript-bot commented Aug 21, 2023

Uh oh!

typescript-bot commented Aug 21, 2023

Uh oh!

typescript-bot commented Aug 21, 2023

Uh oh!

Uh oh!

typescript-bot commented Aug 21, 2023 •

edited

Loading

typescript-bot commented Aug 21, 2023 •

edited

Loading

typescript-bot commented Aug 21, 2023 •

edited

Loading

typescript-bot commented Aug 21, 2023 •

edited

Loading

typescript-bot commented Aug 21, 2023 •

edited

Loading

typescript-bot commented Aug 21, 2023 •

edited

Loading

typescript-bot commented Aug 21, 2023 •

edited

Loading

typescript-bot commented Aug 21, 2023 •

edited

Loading