Fix double error on invalid delete of readonly property

[galabra]

Fixes #53082

Whenever we detect there's an error of type The_operand_of_a_delete_operator_cannot_be_a_read_only_property, we don't need to check for the The_operand_of_a_delete_operator_must_be_optional error.

[typescript-bot]

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

[jakebailey]

This seems reasonable, but, it still needs some sort of test. Potentially one like those in inconsistentErrorInEditor.ts?

[jakebailey]

@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot user test tsserver
@typescript-bot test tsserver top100
@typescript-bot run dt
@typescript-bot perf test this
@typescript-bot pack this

[typescript-bot]

Heya @jakebailey, I've started to run the extended test suite on this PR at f0690e4. You can monitor the build here.

[typescript-bot]

Heya @jakebailey, I've started to run the diff-based user code test suite (tsserver) on this PR at f0690e4. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at f0690e4. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @jakebailey, I've started to run the perf test suite on this PR at f0690e4. You can monitor the build here.

[typescript-bot]

Heya @jakebailey, I've started to run the tarball bundle task on this PR at f0690e4. You can monitor the build here.

[typescript-bot]

Heya @jakebailey, I've started to run the diff-based top-repos suite (tsserver) on this PR at f0690e4. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at f0690e4. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at f0690e4. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/153170/artifacts?artifactName=tgz&fileId=DA04E94F1A41122AE1E27FE39B311765ED63147BA709B665F88461AF21FC671602&fileName=/typescript-5.1.0-insiders.20230424.tgz"
    }
}

and then running npm install.

[typescript-bot]

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/53961/merge:

There were infrastructure failures potentially unrelated to your change:

• 1 instance of "Package install failed"

Otherwise...

Everything looks good!

[typescript-bot]

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/53961/merge:

Everything looks good!

[typescript-bot]

Hey @jakebailey, it looks like the DT test run failed. Please check the log for more details.
You can check the log here.

[typescript-bot]

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/53961/merge:

Everything looks good!

[jakebailey]

@typescript-bot pack this

[typescript-bot]

Heya @jakebailey, I've started to run the tarball bundle task on this PR at f0690e4. You can monitor the build here.

[typescript-bot]

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/153177/artifacts?artifactName=tgz&fileId=DA04E94F1A41122AE1E27FE39B311765ED63147BA709B665F88461AF21FC671602&fileName=/typescript-5.1.0-insiders.20230424.tgz"
    }
}

and then running npm install.

---

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/[email protected]".;

[typescript-bot]

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/53961/merge:

Everything looks good!

[sheetalkamat]

Pls add test

[jakebailey]

#53082 was fixed by #55449, so this PR is no longer needed.