Do not report errors for classes and interfaces merging #5290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
|
|
||
| var bar = new Bar(); | ||
| bar.classFooMethod().interfaceFooMethod().classBarMethod().classFooMethod(); |
There was a problem hiding this comment.
I kind of expected the last method to be interfaceBarMethod(); since all the others are used and classFooMethod() appears twice.
|
One small comment, otherwise 👍 |
| // Checking class with other things in type space not value space | ||
|
|
||
| // class then interface | ||
| class c11 { // error | ||
| ~~~ | ||
| !!! error TS2518: Only an ambient class can be merged with an interface. | ||
| foo() { | ||
| return 1; | ||
| } | ||
| } | ||
|
|
||
| interface c11 { // error |
|
👍 |
mhegazy
added a commit
that referenced
this pull request
Oct 16, 2015
Do not report errors for classes and interfaces merging
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #5269, this removes the restriction for non-ambient classes merging with interfaces.