chore(package.json): pin dev dependency package to known good #551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "jasmine-core": "2.2.0", | ||
| "lodash": "3.5.0", | ||
| "platform": "1.3.0", | ||
| "promise": "7.0.3", | ||
| "protractor": "2.2.0", | ||
| "rx": "latest", |
There was a problem hiding this comment.
still picking rx as latest to be used in micro perf (micro perf test is only consumer for rx for now) for getting comparison number with latest. Debatable though, since had issues with regression recently(#501).
|
...and this is failing with
. I'll try to find out reason and update PR accordingly. |
|
Now Travis is happy with this. |
| "http-server": "0.8.0", | ||
| "istanbul": "0.3.22", | ||
| "jasmine": "2.3.2", | ||
| "jasmine-core": "2.3.4", |
There was a problem hiding this comment.
This was root of failure, bumped up version to latest.
|
This LGTM. |
|
Merged with ee9fd3e. Perfect. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #550
pin dependency package version to known good currently using.