ODSP Client new exposed functionality (DO NOT MERGE) #25597
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: framework
znewton
changed the title
znewton
added a commit
that referenced
this pull request
Oct 9, 2025
) ## Description This PR moves ODSP Container Services into a `class` implementation to prepare for changes coming out of #25597. ## Reviewer Guidance This PR seems pointless on the surface, but it will make life significantly easier when asynchronously adding various functionality to the ODSP Container Services, some of which use class/extension syntax.
Contributor
|
🔗 Found some broken links! 💔 Run a link check locally to find them. See linkcheck output |
znewton
added a commit
that referenced
this pull request
Oct 30, 2025
## Description #25597 includes several changes that require exposing a slightly different, ODSPClient-specific `IFluidContainer` that exposes container methods like `serialize` and `uploadBlob`. Additionally, ODSPClient already returns a customized version of `FluidContainer` with an overwritten `attach` method, but the param types are not represented in the standard IFluidContainer type. ## Breaking Changes None. ## Reviewer Guidance For examples of how this interface will be extended, see #25597. --------- Co-authored-by: Copilot <[email protected]>
This was referenced Nov 3, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are several API functionalities that need to be exposed by ODSP Client for consumer use. However, they will all involve separate API reviews. This is just to get them all in 1 place and compiling.
To be broken down later.
Breaking Changes
Yes
Reviewer Guidance
This will be split up, don't panic.