-
Notifications
You must be signed in to change notification settings - Fork 559
Create odsp-client-specific fluidcontainer interface #25727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create odsp-client-specific fluidcontainer interface #25727
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new IOdspFluidContainer interface that extends the standard IFluidContainer to accommodate ODSP-specific behavior. The main purpose is to properly type the attach method override that already exists in OdspClient, which uses OdspContainerAttachProps instead of the standard ContainerAttachProps.
Key changes:
- Creates
IOdspFluidContainerinterface extendingIFluidContainerwith an overriddenattachmethod signature - Updates return types in
OdspClientmethods fromIFluidContainertoIOdspFluidContainer - Removes type casting by properly typing the generic parameters
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/service-clients/odsp-client/src/interfaces.ts | Adds new IOdspFluidContainer interface with ODSP-specific attach method signature |
| packages/service-clients/odsp-client/src/odspClient.ts | Updates return types to use IOdspFluidContainer and adds generic type parameters to eliminate type casts |
|
🔗 Found some broken links! 💔 Run a link check locally to find them. See linkcheck output |
Description
#25597 includes several changes that require exposing a slightly different, ODSPClient-specific
IFluidContainerthat exposes container methods likeserializeanduploadBlob. Additionally, ODSPClient already returns a customized version ofFluidContainerwith an overwrittenattachmethod, but the param types are not represented in the standard IFluidContainer type.Breaking Changes
None. The types introduced here are accurate to the existing types returned by OdspClient, but now they are explicitly specified.
Reviewer Guidance
For examples of how this interface will be extended, see #25597.