Skip to content

[FS Integration] SVCITEM-CUSTASSET mapping ignores "Convert to Customer Asset" flag — every Service Item synced to FS unconditionally#9322

Open
tomasevicst wants to merge 1 commit into
mainfrom
bugs/640250_SVCITEM_CUSTASSET_mapping_improvement
Open

[FS Integration] SVCITEM-CUSTASSET mapping ignores "Convert to Customer Asset" flag — every Service Item synced to FS unconditionally#9322
tomasevicst wants to merge 1 commit into
mainfrom
bugs/640250_SVCITEM_CUSTASSET_mapping_improvement

Conversation

@tomasevicst

@tomasevicst tomasevicst commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Summary
This change fixes a gap in Field Service Integration where Service Items were synced to Field Service Customer Assets without honoring the Dataverse Product setting Convert to Customer Asset.

Problem
SVCITEM-CUSTASSET synchronization pushed all eligible Service Items, even when the linked Dataverse Product had Convert to Customer Asset set to No.

Root Cause

  1. Field Service Integration did not expose the Dataverse Product field msdyn_converttocustomerasset.
  2. Service Item records had no per-record post-filter logic in OnQueryPostFilterIgnoreRecord.

Behavior After Fix
For SVCITEM-CUSTASSET candidates:

  1. Resolve Service Item -> Item.
  2. Resolve Item -> coupled CRM Product.
  3. If ConvertToCustomerAsset is false, skip record.
  4. If lookup data is missing, do not force skip.

Product type is intentionally not evaluated. Convert to Customer Asset is the deciding signal.

What & why

Linked work

Fixes AB#640250

How I validated this

  • I read the full diff and it contains only changes I intended.
  • I built the affected app(s) locally with no new analyzer warnings.
  • I ran the change in Business Central and confirmed it behaves as expected.
  • I added or updated tests for the new behavior, or explained below why none are needed.

What I tested and the outcome (required — be specific: scenarios, commands, screenshots for UI changes)

Risk & compatibility

@tomasevicst tomasevicst requested a review from a team July 10, 2026 21:36
@github-actions github-actions Bot added the AL: Apps (W1) Add-on apps for W1 label Jul 10, 2026
@github-actions github-actions Bot added this to the Version 29.0 milestone Jul 10, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Copilot PR Review

Iteration 1 · Outcome: completed

All applicable sub-skills completed; al-upgrade-review and al-ui-review were not-applicable (no upgrade or page/UI changes in the diff). No knowledge-backed or agent findings cleared the reporting bar.

Knowledge source: https://github.com/microsoft/BCQuality@822cae1b2771ac25f665f73369f69093bd4fd630

Orchestrator pre-filter (13 file(s) excluded)

  • layer-disabled (knowledge) : 13 file(s)

Findings produced by the Copilot CLI agent against BCQuality at 822cae1b2771ac25f665f73369f69093bd4fd630. Reply 👎 on any inline comment to flag false positives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AL: Apps (W1) Add-on apps for W1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant