Remove special handling of 404/301 from JDK HTTP client instrumentation #5838
+45
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See micrometer-metricsgh-5812 Signed-off-by: Johnny Lim <[email protected]>
5 tasks
big-cir
reviewed
Jan 30, 2025
Comment on lines
56
to
58
| String getUri(HttpRequest request, @Nullable HttpResponse<?> httpResponse, | ||
| Function<HttpRequest, String> uriMapper) { | ||
| return httpResponse != null && (httpResponse.statusCode() == 404 || httpResponse.statusCode() == 301) | ||
| ? "NOT_FOUND" : uriMapper.apply(request); | ||
| return uriMapper.apply(request); |
There was a problem hiding this comment.
@izeye
How about removing the unused @Nullable HttpResponse<?> httpResponse parameter as it's not utilized in the method?
Is there a reason you didn't remove it?
Signed-off-by: Johnny Lim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes special handling of 404/301 from JDK HTTP client instrumentation.
See gh-5812