-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove special handling of 404 status in HTTP client instrumentations #5812
Comments
shakuzen
added a commit
to shakuzen/micrometer
that referenced
this issue
Jan 20, 2025
jonatan-ivanov
pushed a commit
that referenced
this issue
Jan 21, 2025
big-cir
added a commit
to big-cir/micrometer
that referenced
this issue
Jan 25, 2025
…ient instrumentation See micrometer-metricsgh-5812
big-cir
added a commit
to big-cir/micrometer
that referenced
this issue
Jan 25, 2025
…ient instrumentation See micrometer-metricsgh-5812 Signed-off-by: dae won <[email protected]>
shakuzen
pushed a commit
that referenced
this issue
Jan 27, 2025
…ient instrumentation (#5825) See gh-5812 Signed-off-by: dae won <[email protected]>
izeye
added a commit
to izeye/micrometer
that referenced
this issue
Jan 29, 2025
…al handling for 404 See micrometer-metricsgh-5812 Signed-off-by: Johnny Lim <[email protected]>
izeye
added a commit
to izeye/micrometer
that referenced
this issue
Jan 29, 2025
…al handling for 404 See micrometer-metricsgh-5812 Signed-off-by: Johnny Lim <[email protected]>
izeye
added a commit
to izeye/micrometer
that referenced
this issue
Jan 29, 2025
See micrometer-metricsgh-5812 Signed-off-by: Johnny Lim <[email protected]>
big-cir
added a commit
to big-cir/micrometer
that referenced
this issue
Jan 30, 2025
big-cir
added a commit
to big-cir/micrometer
that referenced
this issue
Jan 30, 2025
See micrometer-metricsgh-5812 Signed-off-by: bigcir <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is a tracking issue for all the specific instrumentations that need to be updated. Existing HTTP client instrumentations should be updated to remove the special handling of 404 status responses. This has come up a few times in issues such as #2410. The reasoning for the special handling of 404 and some redirection statuses makes sense for server-side instrumentation but the same reasoning does not apply to client-side instrumentation where the user is in control and responsible for what requests are being made and configuring an appropriate URL mapper. The default URL mapper should provide a safe default (typically returning a constant value for the URL tag), so this change does not affect the default safety, but users who wrote URL mappers relying on the special handling (outside the URL mapper) of 404/etc statuses will need to update their implementation if that handling is what they want.
HTTP client instrumentation to update:
The text was updated successfully, but these errors were encountered: