Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove special handling of 404 status in HTTP client instrumentations #5812

Open
2 of 5 tasks
shakuzen opened this issue Jan 20, 2025 · 1 comment
Open
2 of 5 tasks

Comments

@shakuzen
Copy link
Member

shakuzen commented Jan 20, 2025

This is a tracking issue for all the specific instrumentations that need to be updated. Existing HTTP client instrumentations should be updated to remove the special handling of 404 status responses. This has come up a few times in issues such as #2410. The reasoning for the special handling of 404 and some redirection statuses makes sense for server-side instrumentation but the same reasoning does not apply to client-side instrumentation where the user is in control and responsible for what requests are being made and configuring an appropriate URL mapper. The default URL mapper should provide a safe default (typically returning a constant value for the URL tag), so this change does not affect the default safety, but users who wrote URL mappers relying on the special handling (outside the URL mapper) of 404/etc statuses will need to update their implementation if that handling is what they want.

HTTP client instrumentation to update:

big-cir added a commit to big-cir/micrometer that referenced this issue Jan 25, 2025
big-cir added a commit to big-cir/micrometer that referenced this issue Jan 25, 2025
shakuzen pushed a commit that referenced this issue Jan 27, 2025
izeye added a commit to izeye/micrometer that referenced this issue Jan 29, 2025
izeye added a commit to izeye/micrometer that referenced this issue Jan 29, 2025
izeye added a commit to izeye/micrometer that referenced this issue Jan 29, 2025
@izeye
Copy link
Contributor

izeye commented Jan 29, 2025

I created #5837 for Apache (Async) HTTP clients and #5838 for JDK HTTP client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants