New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove special handling of 404 and redirection statuses from Jetty client instrumentation #5825

Merged

shakuzen merged 1 commit into micrometer-metrics:main from big-cir:jetty-no-more-404-redirection

Jan 27, 2025

+1 −45

Contributor

big-cir commented Jan 25, 2025

Overview

Made corresponding changes in JettyClientTags and JettyClientKeyValues class

Removed special handling for 404 status code in the uri method.
Removed special handling for redirection status codes in the uri method.

Related

ISSUE: #5812


          Remove special handling of 404 and redirection statuses from Jetty cl…

ab45ca9

…ient instrumentation

See micrometer-metricsgh-5812

Signed-off-by: dae won <[email protected]>

big-cir force-pushed the jetty-no-more-404-redirection branch from 5ab791f to ab45ca9 Compare

January 25, 2025 14:18

shakuzen added instrumentation module: jetty12 enhancement labels

shakuzen added this to the 1.15.0-M2 milestone

shakuzen approved these changes

View reviewed changes

Member

shakuzen left a comment

Thank you for the pull request. It looks good to me.

shakuzen merged commit 0540899 into micrometer-metrics:main

8 checks passed

shakuzen mentioned this pull request

Remove special handling of 404 status in HTTP client instrumentations #5812

Open

5 tasks

Contributor Author

big-cir commented Jan 27, 2025

Thank you for the pull request. It looks good to me.

Thank you! I appreciate you reviewing and merging my pull request. I'm glad I could contribute to this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement instrumentation module: jetty12