refactor(timeline): replace TimelineEventKind with TimelineAction
#4655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4655 +/- ##
==========================================
+ Coverage 85.85% 85.89% +0.04%
==========================================
Files 325 325
Lines 35855 35871 +16
==========================================
+ Hits 30784 30813 +29
+ Misses 5071 5058 -13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7 tasks
This information can be accessed via the `TimelineMetadata::own_user_id` field, which is instantiated only once.
Once again, this information is available in the `TimelineMetadata`.
The intent is that the `TimelineItemContent` can be constructed in a single place, avoiding the need to create it in multiple places.
…and state events
…entKind::AddItem` items
…for non-items This variant will be used to cause side-effects to existing timeline items, because the event they relate to is for an aggregation (edit/reaction/etc.). This is used here for reactions.
…ll edits/responses/ends
bnjbvr
force-pushed
the
bnjbvr/replace-timeline-event-kind
branch
from
1234cc7 to
0071fef
Compare
bnjbvr
changed the title
TimelineEventKindTimelineEventKind with TimelineAction
bnjbvr
force-pushed
the
bnjbvr/replace-timeline-event-kind
branch
from
0071fef to
1011700
Compare
…and add comments
…ems for local events
bnjbvr
force-pushed
the
bnjbvr/replace-timeline-event-kind
branch
from
1011700 to
802049f
Compare
Hywan
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This centralizes (and simplifies, IMO) the creation of new timeline items vs handling of aggregations. Before, this was done partly when creating the (type previously known as)
TimelineEventKindand handling it later in theTimelineEventHandler. Now, the event is analyzed once, and analyzing the event results in three outcomes:TimelineAction::AddItemTimelineAction::HandleAggregationThat way, it should be much simpler to handle aggregation-only events in non-live timelines, which will be handy for thread timelines.
Part of #4869.