refactor(timeline): get rid of HandleEventResult
#5030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5030 +/- ##
==========================================
- Coverage 85.84% 85.83% -0.01%
==========================================
Files 325 324 -1
Lines 35906 35840 -66
==========================================
- Hits 30824 30765 -59
+ Misses 5082 5075 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ply-stored context
…ly_aggregation` As it's now unused.
bnjbvr
force-pushed
the
bnjbvr/timeline-handle-result
branch
from
01d1f23 to
d4d23c5
Compare
…ventMeta` + function parameters
bnjbvr
force-pushed
the
bnjbvr/timeline-handle-result
branch
from
d4d23c5 to
0885037
Compare
stefanceriu
approved these changes
May 14, 2025
Hywan
reviewed
May 16, 2025
| @@ -229,6 +232,55 @@ impl<'a> TimelineStateTransaction<'a> { | |||
| } | |||
| } | |||
|
|
|||
| /// Whether the event should be added to the timeline as a new item. | |||
| fn should_add_event_item<P: RoomDataProvider>( | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another set of simplifications after #4655 landed. I'm a bit less sure about the final commits, but this complexity is hard to tame…