Skip to content
This repository was archived by the owner on Jan 13, 2025. It is now read-only.

feat(checkbox): typescript conversion #4319

Merged
merged 18 commits into from
Feb 5, 2019
Merged

feat(checkbox): typescript conversion #4319

merged 18 commits into from
Feb 5, 2019

Conversation

moog16
Copy link
Contributor

@moog16 moog16 commented Jan 30, 2019 •
edited by acdvorak
Loading

refs #4225

mmalerba
mmalerba suggested changes Jan 31, 2019
View reviewed changes
@moog16 moog16 mentioned this pull request Jan 31, 2019
Merged
@kfranqueiro kfranqueiro mentioned this pull request Jan 31, 2019
Closed
45 tasks
@codecov-io
Copy link

codecov-io commented Jan 31, 2019 •
edited
Loading

Codecov Report

Merging #4319 into feat/typescript will decrease coverage by 0.04%.
The diff coverage is 95.23%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           feat/typescript   #4319      +/-   ##
==================================================
- Coverage            98.45%   98.4%   -0.05%     
==================================================
  Files                   93      93              
  Lines                 5747    5777      +30     
  Branches               775     779       +4     
==================================================
+ Hits                  5658    5685      +27     
- Misses                  89      91       +2     
- Partials                 0       1       +1
Impacted Files Coverage Δ
packages/mdc-checkbox/foundation.ts 96.96% <100%> (ø)
packages/mdc-checkbox/index.ts 95.87% <93.22%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f8a271...49754f5. Read the comment docs.

@mdc-web-bot
Copy link
Collaborator

All 606 screenshot tests passed for commit 15c69bc vs. feat/typescript! 💯🎉

acdvorak
acdvorak reviewed Feb 5, 2019
View reviewed changes
acdvorak
acdvorak suggested changes Feb 5, 2019
View reviewed changes
Copy link
Contributor

@acdvorak acdvorak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small comments, otherwise it looks pretty good

@mdc-web-bot
Copy link
Collaborator

All 621 screenshot tests passed for commit a58e420 vs. feat/typescript! 💯🎉

acdvorak
acdvorak approved these changes Feb 5, 2019
View reviewed changes
Copy link
Contributor

@acdvorak acdvorak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mdc-web-bot
Copy link
Collaborator

All 621 screenshot tests passed for commit 03ed82f vs. feat/typescript! 💯🎉

kfranqueiro
kfranqueiro reviewed Feb 5, 2019
View reviewed changes
@mdc-web-bot
Copy link
Collaborator

All 621 screenshot tests passed for commit 49754f5 vs. feat/typescript! 💯🎉

@acdvorak acdvorak merged commit 2befa88 into feat/typescript Feb 5, 2019
@acdvorak acdvorak deleted the feat/checkbox-ts branch February 5, 2019 23:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kfranqueiro kfranqueiro kfranqueiro left review comments

@acdvorak acdvorak acdvorak approved these changes

@mmalerba mmalerba mmalerba requested changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@moog16 @codecov-io @mdc-web-bot @kfranqueiro @acdvorak @mmalerba @googlebot