-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feat(icon-button): Convert to TypeScript #4325
Conversation
Don't forget to also update
|
Do we also need to update |
@kfranquiero I think we may have missed a few component declarations in |
@moog16 afaict we have done it for every package that's been hit so far, with the exception of animation which doesn't appear in material-components-web/index.js at all. I was assuming it was necessary for the all-in-one build to work? |
Don't think it is necessary since webpack resolves either I would test...but waiting for |
ensure that the all-in-one package compiles without adding the |
Codecov Report
@@ Coverage Diff @@
## feat/typescript #4325 +/- ##
===================================================
+ Coverage 98.39% 98.39% +<.01%
===================================================
Files 93 93
Lines 5793 5803 +10
Branches 782 784 +2
===================================================
+ Hits 5700 5710 +10
Misses 92 92
Partials 1 1
Continue to review full report at Codecov.
|
All 621 screenshot tests passed for commit 3f76537 vs. |
All 621 screenshot tests passed for commit b7aed18 vs. |
All 621 screenshot tests passed for commit 213088c vs. |
All 621 screenshot tests passed for commit 8f022e3 vs. |
All 621 screenshot tests passed for commit 8c460ec vs. |
All 621 screenshot tests passed for commit dd61d5a vs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
All 621 screenshot tests passed for commit fe14419 vs. |
Refs #4225