Skip to content
This repository was archived by the owner on Jan 13, 2025. It is now read-only.

feat(form-field): typescript conversion #4292

Closed
wants to merge 16 commits into from
Closed

feat(form-field): typescript conversion #4292

wants to merge 16 commits into from

Conversation

moog16
Copy link
Contributor

@moog16 moog16 commented Jan 24, 2019 •
edited
Loading

related #4225

dependent on #4286

@kfranqueiro kfranqueiro mentioned this pull request Jan 24, 2019
Closed
45 tasks
@codecov-io
Copy link

codecov-io commented Jan 25, 2019 •
edited
Loading

Codecov Report

Merging #4292 into feat/typescript will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           feat/typescript    #4292      +/-   ##
===================================================
+ Coverage            98.57%   98.59%   +0.01%     
===================================================
  Files                   92       91       -1     
  Lines                 5674     5682       +8     
  Branches               760      763       +3     
===================================================
+ Hits                  5593     5602       +9     
+ Misses                  81       80       -1
Impacted Files Coverage Δ
packages/mdc-form-field/foundation.ts 100% <100%> (ø)
packages/mdc-form-field/index.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c649de5...2f0b1e2. Read the comment docs.

@mdc-web-bot
Copy link
Collaborator

All 758 screenshot tests passed for commit e1a5ad2 vs. feat/typescript! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 758 screenshot tests passed for commit 7c05539 vs. feat/typescript! 💯🎉

@moog16 moog16 mentioned this pull request Jan 30, 2019
Merged
@mmalerba mmalerba mentioned this pull request Jan 30, 2019
Merged
mmalerba
mmalerba reviewed Jan 30, 2019
View reviewed changes
packages/mdc-form-field/adapter.ts
* - event handlers
* - ripple activation
*
* Additionally, provides type information for the adapter to the Closure
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can save most of this comment, just take out the bit about Closure

kfranqueiro
kfranqueiro reviewed Jan 30, 2019
View reviewed changes
Copy link
Contributor

@kfranqueiro kfranqueiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this branch need to be watered? I think it's failing the build because it's finding ripple/index.js but we have ripple/index.ts on feat/typescript.

packages/mdc-form-field/adapter.ts Outdated
* - event handlers
* - ripple activation
*
* Additionally, provides type information for the adapter to the Closure
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you wanted to remove this line?

@moog16
Copy link
Contributor Author

moog16 commented Jan 31, 2019

Don't know what happened...some kind of merge conflict. I'm going to just open a new pr and close this one.

@moog16 moog16 closed this Jan 31, 2019
@moog16 moog16 mentioned this pull request Jan 31, 2019
Merged
@moog16 moog16 deleted the feat/form-field-ts branch June 28, 2019 17:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kfranqueiro kfranqueiro kfranqueiro left review comments

@mmalerba mmalerba mmalerba left review comments

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@moog16 @codecov-io @mdc-web-bot @kfranqueiro @mmalerba @googlebot