Skip to content
This repository was archived by the owner on Jan 13, 2025. It is now read-only.

feat(animation): Convert JS to TypeScript #4271

Merged
merged 7 commits into from
Jan 23, 2019

Conversation

acdvorak
Copy link
Contributor

Refs #4225

@codecov-io
Copy link

codecov-io commented Jan 19, 2019

Codecov Report

Merging #4271 into feat/typescript will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           feat/typescript    #4271      +/-   ##
===================================================
+ Coverage            98.56%   98.57%   +<.01%     
===================================================
  Files                   92       92              
  Lines                 5633     5665      +32     
  Branches               759      757       -2     
===================================================
+ Hits                  5552     5584      +32     
  Misses                  81       81
Impacted Files Coverage Δ
packages/mdc-linear-progress/foundation.js 100% <ø> (ø) ⬆️
packages/mdc-tabs/tab-bar/foundation.js 100% <100%> (ø) ⬆️
packages/mdc-animation/index.ts 100% <100%> (ø)
packages/mdc-slider/foundation.js 100% <100%> (ø) ⬆️
packages/mdc-checkbox/index.js 98.8% <100%> (+0.01%) ⬆️
packages/mdc-tabs/tab-bar-scroller/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66c8d81...73ae286. Read the comment docs.

@mdc-web-bot
Copy link
Collaborator

All 758 screenshot tests passed for commit d76279d vs. feat/typescript! 💯🎉

Copy link
Contributor

@moog16 moog16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some changes to return types and property types.

Copy link
Contributor

@moog16 moog16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

return Boolean(windowObj.document) && typeof windowObj.document.createElement === 'function';
}

function getCorrectPropertyName(windowObj: Window, cssProperty: StandardCssPropertyName):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks awesome! 💯

@mdc-web-bot
Copy link
Collaborator

All 758 screenshot tests passed for commit 73ae286 vs. feat/typescript! 💯🎉

@acdvorak acdvorak merged commit 87a5e8e into feat/typescript Jan 23, 2019
@acdvorak acdvorak deleted the feat/typescript--animation branch January 23, 2019 18:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants