-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feat(animation): Convert JS to TypeScript #4271
Conversation
Codecov Report
@@ Coverage Diff @@
## feat/typescript #4271 +/- ##
===================================================
+ Coverage 98.56% 98.57% +<.01%
===================================================
Files 92 92
Lines 5633 5665 +32
Branches 759 757 -2
===================================================
+ Hits 5552 5584 +32
Misses 81 81
Continue to review full report at Codecov.
|
All 758 screenshot tests passed for commit d76279d vs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some changes to return types and property types.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
return Boolean(windowObj.document) && typeof windowObj.document.createElement === 'function'; | ||
} | ||
|
||
function getCorrectPropertyName(windowObj: Window, cssProperty: StandardCssPropertyName): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks awesome! 💯
All 758 screenshot tests passed for commit 73ae286 vs. |
Refs #4225