feat(linear-progress): Convert JS to TypeScript #4272

acdvorak · 2019-01-19T04:16:44Z

moog16

I am also getting lint errors, and some tests errors. Looks like unit tests are not running on this branch since it branches from mdc-animation conversion branch

packages/mdc-linear-progress/foundation.ts

moog16 · 2019-01-22T19:15:54Z

packages/mdc-linear-progress/foundation.ts

+      getPrimaryBar: () => null,
+      hasClass: (_className: string) => false,
+      removeClass: (_className: string) => {},
+      setStyle: (_el: HTMLElement, _styleProperty: string, _value: string) => {},


is the _styleProperty better suited as type [key: CSSStyleDeclaration]?

I don't think we can't use keyof CSSStyleDeclaration here because it lacks vendor prefixes:

material-components-web/packages/mdc-animation/index.ts

Line 69 in 73ae286

const transformStyleProperties = ['transform', 'WebkitTransform', 'MozTransform', 'OTransform', 'MSTransform'];

material-components-web/packages/mdc-linear-progress/foundation.ts

Lines 106 to 108 in 3a874f5

transformStyleProperties.forEach((transformStyleProperty) => {

this.adapter_.setStyle(el, transformStyleProperty, value);

});

material-components-web/packages/mdc-linear-progress/index.ts

Line 65 in 3a874f5

setStyle: (el: HTMLElement, styleProperty: string, value: string) => el.style.setProperty(styleProperty, value),

I'm pretty sure we can get rid of transformStyleProperties because all major browsers now implement transform either unprefixed or -webkit-prefixed, according to Can I Use.

Even so, getCorrectPropertyName() returns StandardCssPropertyName | PrefixedCssPropertyName, which is not directly type-compatible with
keyof CSSStyleDeclaration.

WDYT?

moog16 · 2019-01-22T19:23:37Z

packages/mdc-linear-progress/index.ts

    return new MDCLinearProgress(root);
  }

-  set determinate(value) {
+  set determinate(value: boolean) {


ts compiler says it is returning a boolean. Is that correct?

No; I tried adding a return value and got a TypeScript error:

TS2408: Setters cannot return a value

packages/mdc-linear-progress/adapter.ts

packages/mdc-linear-progress/foundation.ts

…tion--linear-progress

…nt` (to support wrapper frameworks)

…r-progress

codecov-io · 2019-01-23T19:06:11Z

Codecov Report

Merging #4272 into feat/typescript will increase coverage by <.01%.
The diff coverage is 100%.

@@                 Coverage Diff                 @@
##           feat/typescript    #4272      +/-   ##
===================================================
+ Coverage            98.57%   98.57%   +<.01%     
===================================================
  Files                   92       92              
  Lines                 5665     5674       +9     
  Branches               757      760       +3     
===================================================
+ Hits                  5584     5593       +9     
  Misses                  81       81

Impacted Files	Coverage Δ
packages/mdc-animation/index.ts	`100% <ø> (ø)`	⬆️
packages/mdc-linear-progress/foundation.ts	`100% <100%> (ø)`
packages/mdc-linear-progress/index.ts	`100% <100%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8addf4d...2eb71c9. Read the comment docs.

mdc-web-bot · 2019-01-23T19:15:21Z

All 758 screenshot tests passed for commit 55e3642 vs. feat/typescript! 💯🎉

moog16

One comment, but looks good to me otherwise.

packages/mdc-linear-progress/adapter.ts

mdc-web-bot · 2019-01-23T20:03:49Z

All 758 screenshot tests passed for commit 2eb71c9 vs. feat/typescript! 💯🎉

acdvorak added 2 commits January 18, 2019 17:24

feat(animation): Convert JS to TypeScript

d76279d

Refs #4225

feat(linear-progress): Convert JS to TypeScript

3a874f5

Refs #4225

acdvorak assigned moog16 Jan 19, 2019

acdvorak requested a review from moog16 January 19, 2019 04:16

googlebot added the cla: yes label Jan 19, 2019

kfranqueiro mentioned this pull request Jan 19, 2019

Convert packages to TypeScript #4225

Closed

45 tasks

moog16 suggested changes Jan 22, 2019

View reviewed changes

acdvorak added 6 commits January 22, 2019 15:47

WIP: Create enums for argument/return values; update usages to pass enum

ec6de3f

WIP: Destructure enum members to make their usages more readable

9145b18

WIP: Remove "Usage within Web Frameworks" heading

f331dae

WIP: Replace hard-coded string in README with fully-qualified enum ref

8ce644c

WIP: Replace remaining hard-coded strings with fully-qualified enum refs

a76fa79

WIP: Inline 2 destructured enum members to avoid variable name confusion

73ae286

mmalerba reviewed Jan 23, 2019

View reviewed changes

packages/mdc-linear-progress/foundation.ts Outdated Show resolved Hide resolved

acdvorak added 4 commits January 22, 2019 16:24

Merge branch 'feat/typescript--animation' into feat/typescript--anima…

f4615bb

…tion--linear-progress

WIP: Remove unnecessary tslint:disable:no-empty

af3dd06

WIP: Nullable return types for adapter methods that return `HTMLEleme…

d8caf25

…nt` (to support wrapper frameworks)

WIP: Remove unnecessary transformStyleProperties

2ef55ca

acdvorak changed the base branch from feat/typescript--animation to feat/typescript January 23, 2019 01:09

Merge branch 'feat/typescript' into feat/typescript--animation--linea…

55e3642

…r-progress

moog16 approved these changes Jan 23, 2019

View reviewed changes

packages/mdc-linear-progress/adapter.ts Show resolved Hide resolved

WIP: Remove export default

2eb71c9

acdvorak merged commit 6b958de into feat/typescript Jan 23, 2019

acdvorak deleted the feat/typescript--animation--linear-progress branch January 23, 2019 20:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(linear-progress): Convert JS to TypeScript #4272

feat(linear-progress): Convert JS to TypeScript #4272

Uh oh!

acdvorak commented Jan 19, 2019 •

edited

Loading

Uh oh!

moog16 left a comment •

edited

Loading

Uh oh!

Uh oh!

moog16 Jan 22, 2019

Uh oh!

acdvorak Jan 23, 2019

Uh oh!

moog16 Jan 22, 2019

Uh oh!

acdvorak Jan 23, 2019

Uh oh!

Uh oh!

Uh oh!

codecov-io commented Jan 23, 2019 •

edited

Loading

Uh oh!

mdc-web-bot commented Jan 23, 2019

Uh oh!

moog16 left a comment

Uh oh!

Uh oh!

mdc-web-bot commented Jan 23, 2019

Uh oh!

Uh oh!

	transformStyleProperties.forEach((transformStyleProperty) => {
	this.adapter_.setStyle(el, transformStyleProperty, value);
	});

feat(linear-progress): Convert JS to TypeScript #4272

feat(linear-progress): Convert JS to TypeScript #4272

Uh oh!

Conversation

acdvorak commented Jan 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

moog16 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

moog16 Jan 22, 2019

Choose a reason for hiding this comment

Uh oh!

acdvorak Jan 23, 2019

Choose a reason for hiding this comment

Uh oh!

moog16 Jan 22, 2019

Choose a reason for hiding this comment

Uh oh!

acdvorak Jan 23, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

codecov-io commented Jan 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mdc-web-bot commented Jan 23, 2019

Uh oh!

moog16 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mdc-web-bot commented Jan 23, 2019

Uh oh!

Uh oh!

acdvorak commented Jan 19, 2019 •

edited

Loading

moog16 left a comment •

edited

Loading

codecov-io commented Jan 23, 2019 •

edited

Loading