feat(infrastructure): add tsconfig, tslint, and build setup #4241

moog16 · 2019-01-10T02:05:41Z

added a tsconfig and tslint
added ts-loader to webpack to get npm start/dev/build to work
removed babylon from package.json and upgraded to @babel/parser
- babylon is deprecated
renamed rewrite-declaration-statements-for-closure.js -> rewrite-declaration-statements-for-typescript.js
- no longer editting export statements
- imports are not relative to the .typescript-tmp/packages directory (as per internal google requirements)
renamed closure-rewrite.js -> typescript-rewrite.js

Tested this by running:

npm run lint
npm run start # hit a few pages to see if there were errros
npm run clean
npm run dist
node scripts/cp-pkgs.js
npm run dev # still needs to run (i assumed)
npm test

TODO: need to update webpack to build ES6 and ES5 dist files

codecov-io · 2019-01-10T02:13:21Z

Codecov Report

❗ No coverage uploaded for pull request base (feat/typescript@e718cb2). Click here to learn what that means.
The diff coverage is 100%.

@@                Coverage Diff                 @@
##             feat/typescript    #4241   +/-   ##
==================================================
  Coverage                   ?   98.47%           
==================================================
  Files                      ?       92           
  Lines                      ?     5624           
  Branches                   ?      758           
==================================================
  Hits                       ?     5538           
  Misses                     ?       86           
  Partials                   ?        0

Impacted Files	Coverage Δ
packages/mdc-base/foundation.ts	`100% <100%> (ø)`
packages/mdc-base/component.ts	`96.55% <100%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e718cb2...c8cd149. Read the comment docs.

mdc-web-bot · 2019-01-10T02:21:29Z

🤖 Beep boop!

Screenshot test report 🚦

4 screenshots changed from master on commit a2bb0e1:

https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2019/01/10/02_18_12_914/report/report.html?utm_source=github&utm_medium=pr_comment

Details

4 Removed:

spec/mdc-textfield/issues/4170.html

kfranqueiro

One issue I'm noticing is that unit tests no longer show coverage at all for the converted mdc-base package, so it seems like we might've lost instrumentation? Maybe we need to update something in karma.conf.js?

CONTRIBUTING.md

package.json

packages/mdc-base/component.ts

packages/mdc-base/foundation.ts

tsconfig.json

moog16 · 2019-01-15T00:33:03Z

@kfranqueiro figured out the istanbul loader...depressing to see that getting this into the react repo took almost 3 days of experimentation, and it was just a few line changes...

scripts/rewrite-declation-statements-for-typescript.js

scripts/typescript-rewrite.sh

scripts/rewrite-declation-statements-for-typescript.js

mdc-web-bot · 2019-01-15T17:30:24Z

All 758 screenshot tests passed for commit 46a7c1f vs. feat/typescript! 💯🎉

…ponents/material-components-web into feat/tsconfig-webpack-setupt push

mdc-web-bot · 2019-01-15T18:45:11Z

All 758 screenshot tests passed for commit af44094 vs. feat/typescript! 💯🎉

package.json

scripts/rewrite-declation-statements-for-typescript.js

.travis.yml

scripts/webpack/js-bundle-factory.js

packages/mdc-base/foundation.ts

packages/mdc-base/index.ts

scripts/check-pkg-for-release.js

mdc-web-bot · 2019-01-16T23:20:19Z

All 758 screenshot tests passed for commit 2578a7e vs. feat/typescript! 💯🎉

…ponents/material-components-web into feat/tsconfig-webpack-setup

These review comments have been resolved, and Abhinay's OOO today

mdc-web-bot · 2019-01-16T23:40:18Z

All 758 screenshot tests passed for commit 5fd5092 vs. feat/typescript! 💯🎉

mdc-web-bot · 2019-01-16T23:47:29Z

All 758 screenshot tests passed for commit 8585d61 vs. feat/typescript! 💯🎉

…ponents/material-components-web into feat/tsconfig-webpack-setupt push

mdc-web-bot · 2019-01-17T01:07:37Z

All 758 screenshot tests passed for commit 4f84473 vs. feat/typescript! 💯🎉

kfranqueiro · 2019-01-17T23:06:57Z

Matt is currently investigating an issue causing incorrect branch/function coverage reporting. (It's reporting uncovered branches that don't exist.) This is why unit tests are failing (the unit tests pass but coverage falls below threshold).

moog16 · 2019-01-18T01:58:19Z

Figured out the incorrect branch/function coverage reporting. The side effect is that istanbul package no longer works. This package only reported to the CLI, so it is non-essential.

I moved the statements/branches/functions/lines test into the karma.config.js, which fails if the tests limits are not met.

mdc-web-bot · 2019-01-18T02:13:51Z

All 758 screenshot tests passed for commit 01c6044 vs. feat/typescript! 💯🎉

test/unit/index.js

karma.conf.js

scripts/webpack/js-bundle-factory.js

karma.conf.js

mdc-web-bot · 2019-01-18T17:39:09Z

All 758 screenshot tests passed for commit bafff07 vs. feat/typescript! 💯🎉

mdc-web-bot · 2019-01-18T17:53:57Z

All 758 screenshot tests passed for commit 8f7b603 vs. feat/typescript! 💯🎉

mdc-web-bot · 2019-01-18T19:21:07Z

All 758 screenshot tests passed for commit afae2ea vs. feat/typescript! 💯🎉

mdc-web-bot · 2019-01-18T19:39:42Z

All 758 screenshot tests passed for commit c8cd149 vs. feat/typescript! 💯🎉

googlebot added the cla: yes label Jan 10, 2019

moog16 changed the base branch from master to feat/typescript January 10, 2019 02:05

moog16 assigned acdvorak Jan 10, 2019

Matt Goo added 10 commits January 10, 2019 10:57

WIP: added tslint and tsconfig/webpack updates. TODO: test with base

be65412

feat: add component and foundation for base

84c7798

feat: remove js files

ba117bc

fix: lint

50c3d91

WIP: understand closure tests

0aa0577

WIP: removed babylon package

ed8e3a2

WIP: rewrite rewrite script

fe47f1d

fix: imports

7a25c20

fix: lint

a0a58b9

fix: closure tests on trvis

2a9da2e

moog16 force-pushed the feat/tsconfig-webpack-setup branch from 6aa3286 to 2a9da2e Compare January 10, 2019 19:00

kfranqueiro suggested changes Jan 14, 2019

View reviewed changes

Matt Goo added 2 commits January 14, 2019 16:23

fix: strict typings in foundation, eslint/tslint updates

110d93c

fix: karmaconfig to run over ts files

24eab16

abhiomkar self-assigned this Jan 15, 2019

abhiomkar previously requested changes Jan 15, 2019

View reviewed changes

scripts/rewrite-declation-statements-for-typescript.js Outdated Show resolved Hide resolved

scripts/typescript-rewrite.sh Outdated Show resolved Hide resolved

scripts/rewrite-declation-statements-for-typescript.js Outdated Show resolved Hide resolved

WIP Add feat/typescript branch to .travis.yml

46a7c1f

Matt Goo added 2 commits January 15, 2019 10:27

fix: remove typescriptWhitelist

33a20d5

Merge branch 'feat/tsconfig-webpack-setup' of github.com:material-com…

af44094

…ponents/material-components-web into feat/tsconfig-webpack-setupt push

kfranqueiro suggested changes Jan 15, 2019

View reviewed changes

fix: remove typescriptwhitlist

46237c8

moog16 force-pushed the feat/tsconfig-webpack-setup branch from a0d3422 to 46237c8 Compare January 15, 2019 22:36

WIP Minor cleanup

2578a7e

Matt Goo and others added 3 commits January 16, 2019 15:23

fix: add back relative path

ed44ff3

Merge branch 'feat/tsconfig-webpack-setup' of github.com:material-com…

5fd5092

…ponents/material-components-web into feat/tsconfig-webpack-setup

WIP More cleanup

8585d61

kfranqueiro approved these changes Jan 16, 2019

View reviewed changes

Matt Goo added 2 commits January 16, 2019 16:50

fix: karmaconf to new karma-coverage-istanbul-reporter syntax

cf7c1c2

Merge branch 'feat/tsconfig-webpack-setup' of github.com:material-com…

4f84473

…ponents/material-components-web into feat/tsconfig-webpack-setupt push

abhiomkar approved these changes Jan 17, 2019

View reviewed changes

Matt Goo added 2 commits January 17, 2019 15:32

fix: update karma

afb4860

fix: coverage reporting

01c6044

kfranqueiro reviewed Jan 18, 2019

View reviewed changes

Matt Goo added 2 commits January 18, 2019 09:22

Update index.js

bafff07

fix: PR changes

8f7b603

fix: change regex

afae2ea

fix: remove posttest

c8cd149

moog16 merged commit 448918d into feat/typescript Jan 18, 2019

moog16 deleted the feat/tsconfig-webpack-setup branch January 18, 2019 20:41

moog16 pushed a commit that referenced this pull request Jan 18, 2019

feat(infrastructure): add tsconfig, tslint, and build setup (#4241)

8bcf546

feat(infrastructure): add tsconfig, tslint, and build setup #4241

feat(infrastructure): add tsconfig, tslint, and build setup #4241

Uh oh!

Conversation

moog16 commented Jan 10, 2019 • edited by kfranqueiro Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-io commented Jan 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mdc-web-bot commented Jan 10, 2019

Screenshot test report 🚦

4 Removed:

Uh oh!

kfranqueiro left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

moog16 commented Jan 15, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mdc-web-bot commented Jan 15, 2019

Uh oh!

mdc-web-bot commented Jan 15, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mdc-web-bot commented Jan 16, 2019

Uh oh!

mdc-web-bot commented Jan 16, 2019

Uh oh!

mdc-web-bot commented Jan 16, 2019

Uh oh!

mdc-web-bot commented Jan 17, 2019

Uh oh!

kfranqueiro commented Jan 17, 2019

Uh oh!

moog16 commented Jan 18, 2019

Uh oh!

mdc-web-bot commented Jan 18, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mdc-web-bot commented Jan 18, 2019

Uh oh!

mdc-web-bot commented Jan 18, 2019

Uh oh!

mdc-web-bot commented Jan 18, 2019

Uh oh!

mdc-web-bot commented Jan 18, 2019

Uh oh!

Uh oh!

moog16 commented Jan 10, 2019 •

edited by kfranqueiro

Loading

codecov-io commented Jan 10, 2019 •

edited

Loading