Repository navigation
feat(infrastructure): add tsconfig, tslint, and build setup - #4241
Conversation
Codecov Report
@@ Coverage Diff @@
## feat/typescript #4241 +/- ##
==================================================
Coverage ? 98.47%
==================================================
Files ? 92
Lines ? 5624
Branches ? 758
==================================================
Hits ? 5538
Misses ? 86
Partials ? 0
Continue to review full report at Codecov.
|
|
🤖 Beep boop! Screenshot test report 🚦4 screenshots changed from Details4 Removed: |
6aa3286 to
2a9da2e
Compare
kfranqueiro
left a comment
There was a problem hiding this comment.
One issue I'm noticing is that unit tests no longer show coverage at all for the converted mdc-base package, so it seems like we might've lost instrumentation? Maybe we need to update something in karma.conf.js?
|
@kfranqueiro figured out the istanbul loader...depressing to see that getting this into the react repo took almost 3 days of experimentation, and it was just a few line changes... |
|
All 758 screenshot tests passed for commit 46a7c1f vs. |
…ponents/material-components-web into feat/tsconfig-webpack-setupt push
|
All 758 screenshot tests passed for commit af44094 vs. |
a0d3422 to
46237c8
Compare
|
All 758 screenshot tests passed for commit 2578a7e vs. |
…ponents/material-components-web into feat/tsconfig-webpack-setup
These review comments have been resolved, and Abhinay's OOO today
|
All 758 screenshot tests passed for commit 5fd5092 vs. |
|
All 758 screenshot tests passed for commit 8585d61 vs. |
…ponents/material-components-web into feat/tsconfig-webpack-setupt push
|
All 758 screenshot tests passed for commit 4f84473 vs. |
|
Matt is currently investigating an issue causing incorrect branch/function coverage reporting. (It's reporting uncovered branches that don't exist.) This is why unit tests are failing (the unit tests pass but coverage falls below threshold). |
|
Figured out the incorrect branch/function coverage reporting. The side effect is that I moved the statements/branches/functions/lines test into the karma.config.js, which fails if the tests limits are not met. |
|
All 758 screenshot tests passed for commit 01c6044 vs. |
|
All 758 screenshot tests passed for commit bafff07 vs. |
|
All 758 screenshot tests passed for commit 8f7b603 vs. |
|
All 758 screenshot tests passed for commit afae2ea vs. |
|
All 758 screenshot tests passed for commit c8cd149 vs. |
Refs #4225
rewrite-declaration-statements-for-closure.js->rewrite-declaration-statements-for-typescript.jsexportstatementsimportsare not relative to the.typescript-tmp/packagesdirectory (as per internal google requirements)closure-rewrite.js->typescript-rewrite.jsTested this by running:
TODO: need to update webpack to build ES6 and ES5 dist files