Skip to content
This repository was archived by the owner on Jan 13, 2025. It is now read-only.

Commit 2a9da2e

Browse files
author
Matt Goo
committed
fix: closure tests on trvis
1 parent a0a58b9 commit 2a9da2e

File tree

3 files changed

+11
-12
lines changed

3 files changed

+11
-12
lines changed

.travis.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,10 +54,9 @@ matrix:
5454

5555
- node_js: 8
5656
env:
57-
- TEST_SUITE=closure
58-
- CLOSURE=1
57+
- TEST_SUITE=typescript
5958
script:
60-
- if has_testable_files; then npm run test:closure; else log_untestable_files; fi
59+
- if has_testable_files; then npm run test:typescript; else log_untestable_files; fi
6160

6261
- node_js: 8
6362
env:

CONTRIBUTING.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -99,9 +99,9 @@ npm run fix # Runs both of the above commands in parallel
9999
100100
npm run test:watch # Runs karma on Chrome, re-running when source files change
101101
102-
npm test # Lints all files, runs karma, runs closure tests, and then runs coverage enforcement checks.
102+
npm test # Lints all files, runs karma, runs typescript tests, and then runs coverage enforcement checks.
103103
npm run test:unit # Only runs the karma tests
104-
npm run test:closure # Runs closure build tests against all closurized files
104+
npm run test:typescript # Runs typescript build tests against all closurized files
105105
```
106106

107107
#### Running Tests across browsers

scripts/travis-env-vars.sh

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -78,22 +78,22 @@ print_all_changed_files
7878

7979
if [[ "$TEST_SUITE" == 'unit' ]]; then
8080
# Only run unit tests if JS files changed
81-
check_for_testable_files '^karma\.conf\.js$' '^packages/.+\.js$' '^test/unit/.+\.js$'
81+
check_for_testable_files '^karma\.conf\.js$' '^packages/.+\.(js|ts)$' '^test/unit/.+\.js$'
8282
fi
8383

8484
if [[ "$TEST_SUITE" == 'lint' ]]; then
8585
# Only run linter if JS/Sass files changed
86-
check_for_testable_files '\.(js|css|scss)$'
86+
check_for_testable_files '\.(js|ts|css|scss)$'
8787
fi
8888

8989
if [[ "$TEST_SUITE" == 'build' ]]; then
9090
# Only run build if package JS/Sass files changed
91-
check_for_testable_files '^packages/.+\.(js|css|scss)$'
91+
check_for_testable_files '^packages/.+\.(js|ts|css|scss)$'
9292
fi
9393

94-
if [[ "$TEST_SUITE" == 'closure' ]]; then
95-
# Only run closure test if package JS files changed
96-
check_for_testable_files '^packages/.+\.js$'
94+
if [[ "$TEST_SUITE" == 'typescript' ]]; then
95+
# Only run typescript test if package JS files changed
96+
check_for_testable_files '^packages/.+\.(js|ts)$'
9797
fi
9898

9999
if [[ "$TEST_SUITE" == 'site-generator' ]]; then
@@ -103,5 +103,5 @@ fi
103103

104104
if [[ "$TEST_SUITE" == 'screenshot' ]]; then
105105
# Only run screenshot tests if package JS/Sass files, screenshot test files, or image files changed.
106-
check_for_testable_files '^packages/.+\.(js|css|scss)$' '^test/screenshot/' '\.(png|jpg|jpeg|gif|svg)$'
106+
check_for_testable_files '^packages/.+\.(js|ts|css|scss)$' '^test/screenshot/' '\.(png|jpg|jpeg|gif|svg)$'
107107
fi

0 commit comments

Comments
 (0)