Skip to content

Convert comboboxes to inputs for SLDS2 #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 29, 2025
Merged
10 changes: 6 additions & 4 deletions src/scripts/Lookup.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -152,16 +152,18 @@ const LookupSelectedState: FC<LookupSelectedStateProps> = ({
size='small'
/>
)}
<div
<input
type='text'
readOnly
disabled={disabled}
value={selected.label}
role='combobox'
tabIndex={disabled ? -1 : 0}
className='slds-input_faux slds-combobox__input slds-combobox__input-value'
aria-controls={listboxId}
aria-haspopup='listbox'
aria-expanded='false'
>
<span className='slds-truncate'>{selected.label}</span>
</div>
/>
<Button
type='icon'
icon='close'
Expand Down
71 changes: 61 additions & 10 deletions src/scripts/Picklist.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import { FormElement, FormElementProps } from './FormElement';
import { Icon } from './Icon';
import { AutoAlign, RectangleAlignment } from './AutoAlign';
import { DropdownMenuProps } from './DropdownMenu';
import { isElInChildren } from './util';
import { registerStyle, isElInChildren } from './util';
import { ComponentSettingsContext } from './ComponentSettings';
import { useControlledValue, useEventCallback, useMergeRefs } from './hooks';
import { createFC } from './common';
Expand Down Expand Up @@ -67,7 +67,7 @@ function collectOptionValues(children: unknown): PicklistValue[] {
function findSelectedItemLabel(
children: unknown,
selectedValue: PicklistValue
): React.ReactNode | null {
): string | number | null {
return (
React.Children.map(children, (child) => {
if (!React.isValidElement(child)) {
Expand Down Expand Up @@ -107,21 +107,56 @@ function findSelectedItemLabel(
typeof label === 'string' ||
typeof label === 'number' ||
React.isValidElement(label)
? label
? extractTextContent(label)
: undefined;
const childrenValue =
typeof itemChildren === 'string' ||
typeof itemChildren === 'number' ||
React.isValidElement(itemChildren) ||
Array.isArray(itemChildren)
? itemChildren
? extractTextContent(itemChildren)
: undefined;

return labelValue || childrenValue;
}).find((result) => result !== null) ?? null
);
}

/**
* Extract text content from React node recursively
*/
function extractTextContent(node: unknown): string | number | null {
if (node == null) {
return null;
}

if (typeof node === 'string' || typeof node === 'number') {
return node;
}

if (typeof node === 'boolean') {
return String(node);
}

if (Array.isArray(node)) {
return node
.map(extractTextContent)
.filter((result) => result !== null)
.join('');
}

if (
React.isValidElement(node) &&
node.props &&
typeof node.props === 'object' &&
'children' in node.props
) {
return extractTextContent(node.props.children);
}

return null;
}

/**
*
*/
Expand Down Expand Up @@ -150,6 +185,17 @@ const PicklistContext = createContext<{
optionIdPrefix: '',
});

/**
*
*/
function useInitComponentStyle() {
useEffect(() => {
registerStyle('picklist', [
['.react-picklist-input:not(:disabled)', '{ cursor: pointer; }'],
]);
}, []);
}

/**
*
*/
Expand All @@ -174,7 +220,7 @@ export type PicklistProps<MultiSelect extends boolean | undefined> = {
tooltip?: ReactNode;
tooltipIcon?: string;
elementRef?: Ref<HTMLDivElement>;
inputRef?: Ref<HTMLDivElement>;
inputRef?: Ref<HTMLInputElement>;
dropdownRef?: Ref<HTMLDivElement>;
onValueChange?: Bivariant<
(
Expand Down Expand Up @@ -227,6 +273,8 @@ export const Picklist: (<MultiSelect extends boolean | undefined>(
...rprops
} = props;

useInitComponentStyle();

const fallbackId = useId();
const id = id_ ?? fallbackId;
const listboxId = `${id}-listbox`;
Expand Down Expand Up @@ -338,7 +386,7 @@ export const Picklist: (<MultiSelect extends boolean | undefined>(

const elRef = useRef<HTMLDivElement | null>(null);
const elementRef = useMergeRefs([elRef, elementRef_]);
const comboboxElRef = useRef<HTMLDivElement | null>(null);
const comboboxElRef = useRef<HTMLInputElement | null>(null);
const inputRef = useMergeRefs([comboboxElRef, inputRef_]);
const dropdownElRef = useRef<HTMLDivElement | null>(null);
const dropdownRef = useMergeRefs([dropdownElRef, dropdownRef_]);
Expand Down Expand Up @@ -522,6 +570,7 @@ export const Picklist: (<MultiSelect extends boolean | undefined>(
}
);
const inputClassNames = classnames(
'react-picklist-input',
'slds-input_faux',
'slds-combobox__input',
{
Expand Down Expand Up @@ -572,7 +621,8 @@ export const Picklist: (<MultiSelect extends boolean | undefined>(
className='slds-combobox__form-element slds-input-has-icon slds-input-has-icon_right'
role='none'
>
<div
<input
type='text'
ref={inputRef}
role='combobox'
tabIndex={disabled ? -1 : 0}
Expand All @@ -588,9 +638,10 @@ export const Picklist: (<MultiSelect extends boolean | undefined>(
onKeyDown={onKeyDown}
onBlur={onBlur}
{...rprops}
>
<span className='slds-truncate'>{selectedItemLabel}</span>
</div>
value={selectedItemLabel}
readOnly
disabled={disabled}
/>
<Icon
containerClassName='slds-input__icon slds-input__icon_right'
category='utility'
Expand Down