Convert comboboxes to inputs for SLDS2
#494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9d8c620.
|
✨✨ That's perfect, there is no visual difference! ✨✨ Check out the report here. |
msmx-mnakagawa
force-pushed
the
support-slds-2-convert-comboboxes-to-buttons
branch
from
bab5edb to
6314b0d
Compare
msmx-mnakagawa
changed the title
comboboxes to buttons for SLDS2
msmx-mnakagawa
changed the title
comboboxes to buttons for SLDS2comboboxes to buttons for SLDS2
stomita
reviewed
Jul 25, 2025
src/scripts/Lookup.tsx
Outdated
| @@ -161,7 +162,7 @@ const LookupSelectedState: FC<LookupSelectedStateProps> = ({ | |||
| aria-expanded='false' | |||
| > | |||
| <span className='slds-truncate'>{selected.label}</span> | |||
| </div> | |||
| </button> | |||
There was a problem hiding this comment.
Are u willing to change back to button, not the div ? Have u checked the focus difference ?
msmx-mnakagawa
changed the title
comboboxes to buttons for SLDS2comboboxes to inputs for SLDS2
msmx-mnakagawa
force-pushed
the
support-slds-2-convert-comboboxes-to-buttons
branch
from
c04117d to
4adb664
Compare
If you mean the widths of the picklist items, #495 is resolving it.
I fixed it in b226640. |
stomita
requested changes
Jul 29, 2025
src/scripts/Picklist.tsx
Outdated
| function useInitComponentStyle() { | ||
| useEffect(() => { | ||
| registerStyle('picklist', [ | ||
| ['.react-picklist-input:focus-visible', '{ outline: none; }'], |
There was a problem hiding this comment.
If you are willing to cancel the focus ring of the control, it is not working right now.
I think it is not required to remove the ring for the focused picklist.
stomita
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
role="combobox"to<input type="text" readonly />sfindSelectedItemLabel()inPicklist