This repository has been archived by the owner on Jan 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
fix for using search:search using custom constraint instead of extsim… #4
Open
janmichaelyu
wants to merge
2
commits into
marklogic-community:master
Choose a base branch
from
janmichaelyu:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+219
−22
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,114 @@ | ||
import { polyfill } from 'es6-promise'; | ||
import 'isomorphic-fetch'; | ||
|
||
polyfill(); | ||
|
||
export default { | ||
name: 'ValuesApi', | ||
|
||
getValues(name, params, options, searchState, qtext, facetObject) { | ||
//get options | ||
return fetch('/v1/config/query/all?format=json', { | ||
method: 'GET', | ||
headers: { | ||
'Content-Type': 'application/json', | ||
Accept: 'application/json' | ||
}, | ||
credentials: 'same-origin' | ||
}).then( | ||
response => { | ||
return response.json().then(function(json) { | ||
let options = json.options || {}; | ||
|
||
let path = ''; | ||
let collation = ''; | ||
for (let i=0; i < options.constraint.length; i++) { | ||
if (options.constraint[i].name === name){ | ||
path = options.constraint[i].range['path-index'].text; | ||
collation = options.constraint[i].range.collation; | ||
} | ||
} | ||
|
||
options.values = { | ||
name: name, | ||
range: { | ||
collation: collation, | ||
type: 'xs:string', | ||
'path-index': { | ||
text: path, | ||
ns: '' | ||
} | ||
}, | ||
'values-option' : ['frequency-order'] | ||
}; | ||
//combine with search | ||
let searchType = 'all'; | ||
// let searchType = searchType !== undefined ? searchType : 'all'; | ||
let start = facetObject.facetValues.length +1 || 1; | ||
// let start = 1; | ||
let pageLength = 10; | ||
// var limit = 100; | ||
var limit = start + pageLength - 1; | ||
|
||
let facets = Object.keys(searchState.activeFacets || {}).map(function(facetName) { | ||
let constraintType = searchState.activeFacets[facetName].type; | ||
if (constraintType && constraintType.substring(0, 3) === 'xs:') { | ||
constraintType = 'range'; | ||
} | ||
let temp = { | ||
'range-constraint-query' :{ | ||
'constraint-name': facetName, | ||
constraintType: constraintType | ||
} | ||
}; | ||
searchState.activeFacets[facetName].values.map(function(facetValue) { | ||
temp.value = [facetValue.value]; | ||
if (facetValue.negated) { | ||
temp['range-operator'] = 'NE'; | ||
} | ||
}); | ||
|
||
return temp; | ||
}); | ||
let valuesParams = new URLSearchParams(); | ||
valuesParams.append('q', qtext); | ||
valuesParams.append('start', start); | ||
valuesParams.append('pageLength', pageLength); | ||
valuesParams.append('limit', limit); | ||
valuesParams.append('direction', 'descending'); | ||
let valuesParamsString = valuesParams.toString(); | ||
|
||
return fetch('/v1/values/' + name + '?'+valuesParamsString, { | ||
method: 'POST', | ||
headers: { | ||
'Content-Type': 'application/json', | ||
Accept: 'application/json' | ||
}, | ||
body: JSON.stringify({ | ||
search: { | ||
query: { | ||
queries: { | ||
and: [].concat(facets) | ||
}}, | ||
options: options | ||
}}), | ||
credentials: 'same-origin' | ||
}).then( | ||
response => { | ||
return response.json().then(function(json) { | ||
|
||
return { response: json }; | ||
}); | ||
}, | ||
error => { | ||
return error; | ||
} | ||
); | ||
}); | ||
}, | ||
error => { | ||
return error; | ||
} | ||
); | ||
} | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As suggested in the PR against grove-ml-gradle and grove-node, we should put that custom constraint inside all.xml. You can then provide the search type as param to this function, and somehow leverage the search function in this library to make the backend call..