fix for using search:search using custom constraint instead of extsim… #4
Conversation
|
Very interesting! I think we need to send id rather than uri, and the middle-tier needs to translate the id to uri. I also thought you mentioned putting this in a SimilarApi, but to be honest, it makes a lot of sense to put it in SearchApi, particularly since it leans so much on the existing search code. I mentioned not using a separate search options file in the other PRs. A benefit from that would be that you could apply the current search constraints to the similar query. Not entirely sure if a user would always want that, but would be a nice user option to have a toggle for that. |
|
I'm currently thinking to merge this, and refine later. wdyt @mariannemyers ? |
| error => { | ||
| return error; | ||
| } | ||
| ); |
There was a problem hiding this comment.
As suggested in the PR against grove-ml-gradle and grove-node, we should put that custom constraint inside all.xml. You can then provide the search type as param to this function, and somehow leverage the search function in this library to make the backend call..
…ilar.
Required for migrating from a direct fetch to extsimilar to using a custom constraint to get 'similar' results. @grtjn Please review. :)