Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential Fix for Folders Not Working #25

Closed
wants to merge 1 commit into from
Closed

Potential Fix for Folders Not Working #25

wants to merge 1 commit into from

Conversation

camdrit
Copy link

@camdrit camdrit commented Mar 28, 2021

This should partially address #13 specifically in regards to folders not working. Essentially I added a function to recursively get the parent path for nested nodes and additionally added a condition for layer.isGroupLayer to recognize folders.

Tested to work on layers nested multiple groups deep, would be great if someone could review a case with object layers as these are not used by me in my current project.

Other than that, feedback/cleanup on my implementation is definitely desired....running on very little sleep after trying to find a good solution for exporting Tiled maps to performant Godot scenes (thanks very much for this extension, it works fantastically in this regard!) so this may look messy.

add support for folders, multiple nested parents
@bjorn
Copy link
Member

bjorn commented Mar 29, 2021

There seems to be at least one remaining parent: ".", that likely needs to be adjusted to call getLayerParentage, just after } else if (layer.isObjectLayer) {.

Other than that the change seems reasonable, but I haven't tested it,

@MikeMnD
Copy link
Collaborator

MikeMnD commented Mar 23, 2022

I think this is outdated and should be closed.

@MikeMnD MikeMnD closed this Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants