Skip to content

Issue #3 Subset Sum #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 65 additions & 0 deletions dp/is_subset_sum.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,65 @@
"""
Problem: https://en.wikipedia.org/wiki/Subset_sum_problem

Given a set of integers, is there a non-empty subset whose sum is zero?

>>> isSubsetSum([2, 4, 15, 11, 8], 34)
True
>>> isSubsetSum([2, 4, 15, 11, 8], 35)
False
>>> isSubsetSumRecursive([2, 4, 15, 11, 8], 34)
True
>>> isSubsetSumRecursive([2, 4, 15, 11, 8], 35)
False
"""

def isSubsetSum(s, total):
"""Returns true if there is a subset of s with sum total else false"""
return isSubsetSumHelper(s, len(s), total)


def isSubsetSumHelper(s, n, total):
"""Helper function for dynamic programming implementation"""

# The value of subset[i][j] will be true if there is a
# subset of s[0..j-1] with sum equal to i
subset = []
# If sum is 0, then answer is true
for i in range(n + 1):
subset.append([True])

# If sum is not 0 and set is empty, then answer is false
for i in range(1, total + 1):
subset[0].append(False)

# Fill the subset table in botton up manner
for i in range(1, n + 1):
for j in range(1, total + 1):
if j < s[i-1]:
subset[i].append(subset[i-1][j])
if j >= s[i-1]:
subset[i].append(subset[i-1][j] or subset[i - 1][j-s[i-1]])
return subset[n][total]


def isSubsetSumRecursive(s, total):
"""Returns true if there is a subset of s with sum total else false"""
return isSubsetSumRecursiveHelper(s, len(s), total)


def isSubsetSumRecursiveHelper(s, n, total):
"""Helper function for recursive implentation"""
# Base Cases
if (total == 0) :
return True
if (n == 0 and total != 0) :
return False

# If last element is greater than total, then ignore it
if (s[n - 1] > total) :
return isSubsetSumRecursiveHelper(s, n - 1, total);

# else, check if total can be obtained by any of the following
# (a) including the last element
# (b) excluding the last element
return isSubsetSumRecursiveHelper(s, n-1, total) or isSubsetSumRecursiveHelper(s, n-1, total-s[n-1])
16 changes: 16 additions & 0 deletions tests/isSubsetSum_test
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
import unittest
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you write the test case using pytest?
We've moved to automated test builds and use pytest for the same in travis.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can refer this for docs: https://docs.pytest.org/en/latest/

from dp.is_subset_sum import isSubsetSum, isSubsetSumRecursive


class test_issubsetsum(unittest.TestCase):
def test_isSubsetSum(self):
self.assertTrue(isSubsetSum([2, 4, 15, 11, 8], 34))
self.assertFalse(isSubsetSum([2, 4, 15, 11, 8], 35))

def test_isSubsetSumRecursive(self):
self.assertTrue(isSubsetSumRecursive([2, 4, 15, 11, 8], 34))
self.assertFalse(isSubsetSumRecursive([2, 4, 15, 11, 8], 35))


if __name__ == "__main__":
unittest.main()