forked from prakhar1989/Algorithms
-
Notifications
You must be signed in to change notification settings - Fork 8
Issue #3 Subset Sum #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
blueenvelope31
wants to merge
4
commits into
manishrw:master
Choose a base branch
from
blueenvelope31:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+81
−0
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,65 @@ | ||
""" | ||
Problem: https://en.wikipedia.org/wiki/Subset_sum_problem | ||
|
||
Given a set of integers, is there a non-empty subset whose sum is zero? | ||
|
||
>>> isSubsetSum([2, 4, 15, 11, 8], 34) | ||
True | ||
>>> isSubsetSum([2, 4, 15, 11, 8], 35) | ||
False | ||
>>> isSubsetSumRecursive([2, 4, 15, 11, 8], 34) | ||
True | ||
>>> isSubsetSumRecursive([2, 4, 15, 11, 8], 35) | ||
False | ||
""" | ||
|
||
def isSubsetSum(s, total): | ||
"""Returns true if there is a subset of s with sum total else false""" | ||
return isSubsetSumHelper(s, len(s), total) | ||
|
||
|
||
def isSubsetSumHelper(s, n, total): | ||
"""Helper function for dynamic programming implementation""" | ||
|
||
# The value of subset[i][j] will be true if there is a | ||
# subset of s[0..j-1] with sum equal to i | ||
subset = [] | ||
# If sum is 0, then answer is true | ||
for i in range(n + 1): | ||
subset.append([True]) | ||
|
||
# If sum is not 0 and set is empty, then answer is false | ||
for i in range(1, total + 1): | ||
subset[0].append(False) | ||
|
||
# Fill the subset table in botton up manner | ||
for i in range(1, n + 1): | ||
for j in range(1, total + 1): | ||
if j < s[i-1]: | ||
subset[i].append(subset[i-1][j]) | ||
if j >= s[i-1]: | ||
subset[i].append(subset[i-1][j] or subset[i - 1][j-s[i-1]]) | ||
return subset[n][total] | ||
|
||
|
||
def isSubsetSumRecursive(s, total): | ||
"""Returns true if there is a subset of s with sum total else false""" | ||
return isSubsetSumRecursiveHelper(s, len(s), total) | ||
|
||
|
||
def isSubsetSumRecursiveHelper(s, n, total): | ||
"""Helper function for recursive implentation""" | ||
# Base Cases | ||
if (total == 0) : | ||
return True | ||
if (n == 0 and total != 0) : | ||
return False | ||
|
||
# If last element is greater than total, then ignore it | ||
if (s[n - 1] > total) : | ||
return isSubsetSumRecursiveHelper(s, n - 1, total); | ||
|
||
# else, check if total can be obtained by any of the following | ||
# (a) including the last element | ||
# (b) excluding the last element | ||
return isSubsetSumRecursiveHelper(s, n-1, total) or isSubsetSumRecursiveHelper(s, n-1, total-s[n-1]) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
import unittest | ||
from dp.is_subset_sum import isSubsetSum, isSubsetSumRecursive | ||
|
||
|
||
class test_issubsetsum(unittest.TestCase): | ||
def test_isSubsetSum(self): | ||
self.assertTrue(isSubsetSum([2, 4, 15, 11, 8], 34)) | ||
self.assertFalse(isSubsetSum([2, 4, 15, 11, 8], 35)) | ||
|
||
def test_isSubsetSumRecursive(self): | ||
self.assertTrue(isSubsetSumRecursive([2, 4, 15, 11, 8], 34)) | ||
self.assertFalse(isSubsetSumRecursive([2, 4, 15, 11, 8], 35)) | ||
|
||
|
||
if __name__ == "__main__": | ||
unittest.main() |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you write the test case using pytest?
We've moved to automated test builds and use pytest for the same in travis.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can refer this for docs: https://docs.pytest.org/en/latest/