Issue #3 Subset Sum #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manishrw
requested changes
Oct 18, 2018
dp/is_subset_sum.py
Outdated
| @@ -0,0 +1,50 @@ | |||
| def isSubsetSumDP(s, total): | |||
There was a problem hiding this comment.
Could you rename it to isSubsetSum? Let's not mention the word DP in the function name.
dp/is_subset_sum.py
Outdated
| @@ -0,0 +1,50 @@ | |||
| def isSubsetSumDP(s, total): | |||
There was a problem hiding this comment.
Could you also add comments stating what the module is supposed to do?
Also, add doctest in the comments.
dp/is_subset_sum.py
Outdated
| # else, check if total can be obtained by any of the following | ||
| # (a) including the last element | ||
| # (b) excluding the last element | ||
| return isSubsetSumHelper(s, n-1, total) or isSubsetSumHelper(s, n-1, total-s[n-1]) |
There was a problem hiding this comment.
Also, add pytest test case for the same functionality. Please check the other test cases in the test directory for reference.
manishrw
requested changes
Oct 23, 2018
| @@ -0,0 +1,16 @@ | |||
| import unittest | |||
There was a problem hiding this comment.
Can you write the test case using pytest?
We've moved to automated test builds and use pytest for the same in travis.
There was a problem hiding this comment.
You can refer this for docs: https://docs.pytest.org/en/latest/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.