Redesign Warden around database-backed client profiles - #475
Merged
Conversation
MadMaxMangos
marked this pull request as ready for review
August 17, 2026 19:34
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 1304 |
| Duplication | 77 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
MadMaxMangos
force-pushed
the
feature/warden-redesign-base
branch
from
August 17, 2026 22:53
a6a3bdf to
3270623
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3270623a86
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WardenServer/WardenManagerarchitecture and grouped opcode handlerWhy
The previous implementation mixed fixed checks, transport, policy, and persistence, contained incompatible module-initialization checksums, and could not represent exact client profiles safely. This redesign follows the delivered 1.12.x module's verified behavior and keeps check policy in reviewed database rows instead of hardcoded runtime payloads.
Dependencies
Operator impact
Apply the required database updates before startup. The server now requires World
22/06/003, Character22/05/004, and Realm22/04/001; missing, empty, malformed, incomplete, or over-budget catalogues stop startup before player admission. Distributed configuration documents exact-profile admission and enforcement modes.mangosdConfVersionadvances to2026081700, so older local configuration files trigger the existing stale-config warning.Validation
This change is