Skip to content

Harden Warden response timing and transport validation - #477

Merged
MadMaxMangos merged 4 commits into
masterfrom
fix/pr475-adversarial-findings
Aug 20, 2026
Merged

Harden Warden response timing and transport validation#477
MadMaxMangos merged 4 commits into
masterfrom
fix/pr475-adversarial-findings

Conversation

@MadMaxMangos

@MadMaxMangos MadMaxMangos commented Aug 20, 2026

Copy link
Copy Markdown
Member

Summary

Follow-up to #475 based on an adversarial review of the merged Warden redesign.

  • drain queued Warden responses before advancing their deadlines, while preventing elapsed time from being charged to a state entered during the same world tick
  • reject check plans whose maximum client result exceeds the exact 10,229-byte transport body budget
  • distinguish transport overflow from the inner uint16 result limit in catalogue diagnostics
  • centralize and compile-time pin the Classic CHECK_RESULT framing invariants

Verification

  • built mangosd and mangos_tests in RelWithDebInfo
  • full aggregate unit run: 309 tests passed
  • CTest: 15/15 passed
  • proto_boundary, build_policy, and warden_boundary passed
  • each commit received a bounded Claude Opus 5 Max review; no blocking or unresolved important findings remain

No database, configuration, or submodule changes are included.


This change is Reviewable

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 4 complexity · 2 duplication

Metric Results
Complexity 4
Duplication 2

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@MadMaxMangos
MadMaxMangos marked this pull request as ready for review August 20, 2026 12:05
@AppVeyorBot

Copy link
Copy Markdown

@MadMaxMangos
MadMaxMangos merged commit 071bc44 into master Aug 20, 2026
8 checks passed
@MadMaxMangos
MadMaxMangos deleted the fix/pr475-adversarial-findings branch August 20, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants