Conversation
whummer
force-pushed
the
rename-proxy
branch
from
64807e6 to
8b49a05
Compare
nik-localstack
approved these changes
Sep 17, 2025
| from aws_replicator.config import HANDLER_PATH_PROXIES, HANDLER_PATH_REPLICATE | ||
| from aws_replicator.server import ui as web_ui | ||
| from aws_replicator.server.aws_request_forwarder import AwsProxyHandler | ||
| from aws_replicator.shared.models import AddProxyRequest, ReplicateStateRequest, ResourceReplicator |
Contributor
There was a problem hiding this comment.
nit: We could remove the ResourceReplicator interface entirely now that it's not used (from aws_replicator.shared.models)
Member
Author
There was a problem hiding this comment.
Great catch, thanks - was able to do a few more cleanups in models and surrounding modules. 👍
Co-authored-by: Nikos <nikos.michas@localstack.cloud>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR is a step towards renaming the
aws-replicatorextension to the more fitting nameaws-proxy, to avoid confusion with the AWS Replicator.When this project was first developed as an experimental extension, the scope was a bit convoluted, and it tried to address different aspects of enabling hybrid scenarios with LocalStack, including the "replicator" aspect, as well as the "proxy" aspect. The Replicator has graduated in the meantime and is now available as a proper feature in upstream LocalStack (Pro), 🚀 whereas the focus of this extension has been reduced to the Proxy aspect - hence the renaming here.
/cc @nik-localstack Adding you as reviewer since you've recently helped make some changes in this extension. :)
Changes
localstack-extension-aws-replicatortolocalstack-extension-aws-proxyaws_replicatortoaws_proxy0.2.0for this new extensionTODOs: