Fix domain name and routes for AWS Proxy extension#105
Merged
Conversation
Contributor
There was a problem hiding this comment.
nit: We could rename the workflow file to aws-proxy.yml and we could also change the python version here (Set up Python step) to 3.13 (same as LocalStack)
I can make these changes in a follow-up PR though after this get merged.
Member
Author
There was a problem hiding this comment.
Great points - thanks for the detailed review! 🙌 Updated the PR with those changes.. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fix domain name and routes for AWS Proxy extension. Follow-up from #103 .
This was a small oversight in the last refactoring/renaming PR - Currently the extension UI is still available under
https://aws-replicator.localhost.localstack.cloud:4566/, but we want it to be exposed underhttps://aws-proxy.localhost.localstack.cloud:4566/This PR fixes the Web UI setup and removes any remaining mentions of "replicator" in the proxy extension code.
Testing
Tested the changes locally (via
EXTENSION_DEV_MODE=1) and ensured that the new routes work and the Web UI spins up properly. ✅TODOs