[LLHD] Allow multiple layers of inlined functions to be followed by the same op #9119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he same op - This occurs when a function with empty body is inlined. Previously only one call would be popped off the call stack, meaning further uses of the unpopped function would be detected incorrectly as recursive
| // the inlined operations immediately after visiting the call. | ||
| for (auto &block : region) { | ||
| for (auto &op : block) { | ||
| // If this is an op after a call, pop that call off the call stack. |
There was a problem hiding this comment.
Suggested change
| // If this is an op after a call, pop that call off the call stack. | |
| // While this is an op after a call, pop that call off the call stack. |
There was a problem hiding this comment.
I've reworded this to "Pop all calls that are followed by this op off the call stack."
fabianschuiki
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This occurs when a function with empty body is inlined. Previously only one call would be popped off the call stack when the instruction following an inlined call was reached, meaning further uses of the unpopped function would be detected incorrectly as recursive.
This is fixed by repeatedly popping the call stack if possible.