When replacing a register with its reset value, attempt width coercion #8379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwy7
force-pushed
the
fix-reg-canonicalizer
branch
2 times, most recently
from
abf9729 to
f111f9c
Compare
We have a canonicalization which can replace a register with its reset value, if the reset signal is constantly high. However, the reset-value of a register does not have to exactly match the type of the register, it only has to be equivalent. Previously, this canonicalization would fail if the reset value's type doesn't exactly match the register's type. This commit makes the canonicalization attempt to coerce the reset value to the type of the register. The coercion code will perform sign extension or truncation for integers, and will recursively attempt to coerce the elements of a bundle or vector.
rwy7
force-pushed
the
fix-reg-canonicalizer
branch
from
f111f9c to
de395bf
Compare
rwy7
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a canonicalization which can replace a register with its reset
value, if the reset signal is constantly high. However, the reset-value
of a register does not have to exactly match the type of the register,
it only has to be equivalent. Previously, this canonicalization would
fail if the reset value's type doesn't exactly match the register's
type. This commit makes the canonicalization attempt to coerce the
reset value to the type of the register.
The coercion code will perform sign extension or truncation for
integers, and will recursively attempt to coerce the elements of a
bundle or vector.