[MooreToCore] Add nested moore.conditional support #8125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+1349
to
+1448
| if (operation->hasTrait<OpTrait::HasRecursiveMemoryEffects>()) | ||
| return WalkResult::advance(); |
Comment on lines
1010
to
1027
| %5 = moore.conditional %4 : l1 -> l2 { | ||
| %6 = moore.read %b_1 : <l1> | ||
| %7 = moore.conditional %6 : l1 -> l2 { | ||
| moore.yield %2 : l2 | ||
| } { | ||
| moore.yield %1 : l2 | ||
| } | ||
| moore.yield %7 : l2 | ||
| } { | ||
| moore.yield %0 : l2 | ||
| } |
There was a problem hiding this comment.
This test uses quite a few other supporting operations (module, nets, variables, procedure, blocking assigns) to test the conditional lowering. Would it be possible to move just the conditionals and the corresponding checks into a func.func, similar to @Conversions just below? It might be possible to even move it inside of @Conversions. That would make the test less brittle if any of the module and procedure lowerings change, which are unrelated to the conditionals.
There was a problem hiding this comment.
Hi! I simplified test and rebased branch. Could you check it?
AndreyVV-100
force-pushed
the
fix-moore-conditional
branch
from
c7a54ae to
ca52474
Compare
fabianschuiki
approved these changes
Feb 3, 2025
This code adds correct lowering for nested ternary operators like this:
```verilog
module Mod(input a, input b, output logic [1:0] c);
always_comb
c = a ? b ? 2'd0 : 2'd1 : 2'd2;
endmodule
```
AndreyVV-100
force-pushed
the
fix-moore-conditional
branch
from
ce42131 to
982e335
Compare
|
If there are no remarks, could you merge it? I haven't commit access. |
|
Sure thing, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! This code adds correct lowering for nested ternary operators like this: