Skip to content

force interrupt speech in aclose_impl #3485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

force interrupt speech in aclose_impl #3485

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions livekit-agents/livekit/agents/voice/agent_session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -671,13 +671,7 @@ async def _aclose_impl(

if self._activity is not None:
if not drain:
try:
await self._activity.interrupt()
except RuntimeError:
# uninterruptible speech
# TODO(long): force interrupt or wait for it to finish?
# it might be an audio played from the error callback
pass
await self._activity.interrupt(force=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure because the last speech could be an ending/error message that user doesn't want it to be interrupted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, so should i close this PR, or keep it for now?

await self._activity.drain()

# wait any uninterruptible speech to finish
Expand Down