force interrupt speech in aclose_impl #3485
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Panmax
force-pushed
the
feature/aclose
branch
from
2c7ce00 to
4c8e023
Compare
longcw
reviewed
Sep 23, 2025
| # TODO(long): force interrupt or wait for it to finish? | ||
| # it might be an audio played from the error callback | ||
| pass | ||
| await self._activity.interrupt(force=True) |
There was a problem hiding this comment.
I am not sure because the last speech could be an ending/error message that user doesn't want it to be interrupted.
There was a problem hiding this comment.
Okay, so should i close this PR, or keep it for now?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a TODO here before, and I think it can be removed now.