Bump electrum_client dependency and add new TLS-backend features
#3587
Conversation
tnull
force-pushed
the
2025-02-bump-electrum-client
branch
2 times, most recently
from
84fd91e to
d12378d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3587 +/- ##
==========================================
+ Coverage 89.20% 91.00% +1.79%
==========================================
Files 155 156 +1
Lines 119229 135548 +16319
Branches 119229 135548 +16319
==========================================
+ Hits 106363 123358 +16995
+ Misses 10266 9715 -551
+ Partials 2600 2475 -125 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tnull
force-pushed
the
2025-02-bump-electrum-client
branch
3 times, most recently
from
4c96307 to
e4ecb76
Compare
|
Draft for now as in dependency hell :( |
tnull
force-pushed
the
2025-02-bump-electrum-client
branch
4 times, most recently
from
09e929a to
1d09868
Compare
tnull
force-pushed
the
2025-02-bump-electrum-client
branch
4 times, most recently
from
094b538 to
db8c7c2
Compare
|
Blocked on rust-bitcoin/corepc#111 |
tnull
force-pushed
the
2025-02-bump-electrum-client
branch
from
f2b80af to
2cc608a
Compare
.. which is the newest version and also aligns with recent BDK releases.
tnull
force-pushed
the
2025-02-bump-electrum-client
branch
from
2cc608a to
c257589
Compare
|
Discussed with @tnull and we concluded its probably fine to just do a patch for ldk-node release and we can skip backporting this (which technically breaks compat). |
Right, I can probably do without the backport for now. Would still be great to land this PR though. |
Recently `rustls` introduced a new default crypto provider, `aws-lc-rc`. While it generally works fine, it doesn't seem to build properly on `aarch64-apple-ios`. Here, we therefore allow the users to decide which crypto provider the `electrum-client` client should use for its `rustls` TLS backend. To this end, we disable default features while keeping the `proxy` enabled, as it's a prerequisite for the `electrum_client::Client` to be exposed / usable (also see bitcoindevkit/rust-electrum-client#91).
tnull
force-pushed
the
2025-02-bump-electrum-client
branch
from
c641af3 to
d84a776
Compare
|
Going ahead landing this as it has two ACKs, and only the commit message of the last commit was adjusted since. |
We bump our
electrum_clientdependency to v0.22 which is the newest version and also aligns with recent BDK releases.Also, recently
rustlsintroduced a new default crypto provider inaws-lc-rc. Since there have been reports on this new provider not building properly on certain platformselectrum-clientintroducedadditional features allowing the user to configure what backend to use for TLS.
Here, we simply re-expose these features to our users, which also mirrors what we do for Esplora already. Note we avoid changing the behavior of the pre-existing
electrumfeature to make this a backwards compatible change.