Cut v0.5.0 binary releases #533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for assigning @joostjager as a reviewer! |
.. as `lightning-transaction-sync` now requires the `electrum` feature.
tnull
force-pushed
the
2025-04-cut-0.5.0-binaries
branch
from
c8ff340 to
682ed26
Compare
joostjager
reviewed
May 5, 2025
| rustup target add aarch64-apple-ios x86_64-apple-ios --toolchain 1.73.0 | ||
| rustup target add aarch64-apple-ios-sim --toolchain 1.73.0 | ||
| rustup target add aarch64-apple-darwin x86_64-apple-darwin --toolchain 1.73.0 | ||
| rustup upgrade stable |
There was a problem hiding this comment.
Shouldn't this remain deterministic?
There was a problem hiding this comment.
Clarified offline. Stable now surpassed 1.73.0
| @@ -47,7 +47,7 @@ lightning-liquidity = { version = "0.1.0", features = ["std"] } | |||
| #lightning-background-processor = { git = "https://github.com/lightningdevkit/rust-lightning", branch = "main", features = ["futures"] } | |||
| #lightning-rapid-gossip-sync = { git = "https://github.com/lightningdevkit/rust-lightning", branch = "main" } | |||
| #lightning-block-sync = { git = "https://github.com/lightningdevkit/rust-lightning", branch = "main", features = ["rpc-client", "tokio"] } | |||
| #lightning-transaction-sync = { git = "https://github.com/lightningdevkit/rust-lightning", branch = "main", features = ["esplora-async-https", "time"] } | |||
| #lightning-transaction-sync = { git = "https://github.com/lightningdevkit/rust-lightning", branch = "main", features = ["esplora-async-https", "electrum", "time"] } | |||
There was a problem hiding this comment.
Total nit, but order "electrum, time" is different from uncommented version.
| @@ -4,7 +4,7 @@ | |||
| import PackageDescription | |||
|
|
|||
| let tag = "v0.5.0" | |||
| let checksum = "95ea5307eb3a99203e39cfa21d962bfe3e879e62429e8c7cdf5292cae5dc35cc" | |||
| let checksum = "fd9eb84a478402af8f790519a463b6e1bf6ab3987f5951cd8375afb9d39e7a4b" | |||
There was a problem hiding this comment.
What is this checksum and/or where does it come from? Maybe add a code comment.
There was a problem hiding this comment.
Clarified offline - this is the checksum of the released binary.
joostjager
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the required files for/post the 0.5.0 binary releases.
Note the actual binary releases include the recent LDK 0.1.3 release, with a backport of lightningdevkit/rust-lightning#3587, i.e., is based on https://github.com/tnull/rust-lightning/tree/2025-02-bump-electrum-client-backport
as the
aws-lc-rsdependency otherwise fails to build onaarch64-apple-ios.