Skip to content

Only log connection string if listening address present #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benthecarman merged 1 commit into from
Feb 23, 2026
+5 −5
Merged

Only log connection string if listening address present #129

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions ldk-server/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,11 +232,11 @@ fn main() {
},
}

info!(
"CONNECTION_STRING: {}@{}",
node.node_id(),
node.config().listening_addresses.as_ref().unwrap().first().unwrap()
);
if let Some(addresses) = node.config().listening_addresses {
if !addresses.is_empty() {
info!("CONNECTION_STRING: {}@{}", node.node_id(), addresses.first().unwrap());
Copy link
Collaborator

@benthecarman benthecarman Feb 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this still be Some(vec![])? Would be safer to also not unwrap first()

Copy link
Contributor Author

@elnosh elnosh Feb 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried setting it empty/blank in the config i.e listening_addresses = [] and it would error out before this with invalid address. I can remove that unwrap as well though, I guess it wouldn't hurt.

}
}

runtime.block_on(async {
// Register SIGHUP handler for log rotation
Expand Down