Only log connection string if listening address present#129
Open
elnosh wants to merge 1 commit intolightningdevkit:mainfrom
Open
Only log connection string if listening address present#129elnosh wants to merge 1 commit intolightningdevkit:mainfrom
elnosh wants to merge 1 commit intolightningdevkit:mainfrom
Conversation
|
👋 Hi! Please choose at least one reviewer by assigning them on the right bar. |
| ); | ||
| match node.config().listening_addresses { | ||
| Some(addresses) => { | ||
| info!("CONNECTION_STRING: {}@{}", node.node_id(), addresses.first().unwrap()); |
Collaborator
There was a problem hiding this comment.
Could this still be Some(vec![])? Would be safer to also not unwrap first()
Contributor
Author
There was a problem hiding this comment.
I tried setting it empty/blank in the config i.e listening_addresses = [] and it would error out before this with invalid address. I can remove that unwrap as well though, I guess it wouldn't hurt.
elnosh
force-pushed
the
fix-unwrap-address
branch
from
051b915 to
20d9a38
Compare
benthecarman
approved these changes
Feb 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was hitting the unwrap if an address was not present in the config