Cast SNDBUF to UBYTE on callback to fix gcc-14.1 compile #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes gcc-14,1 error
libretro/core-mapper.c: In function 'retro_sound_update':
libretro/core-mapper.c:158:22: error: passing argument 1 of 'Sound_Callback' from incompatible pointer type [-Wincompatible-pointer-types]
158 | Sound_Callback(SNDBUF, 1024*2*2);
| ^~~~~~
| |
| short int *
In file included from ./atari800/src/platform.h:11,
from libretro/core-mapper.c:4:
./atari800/src/sound.h:75:28: note: expected 'unsigned char *' but argument is of type 'short int *'
75 | void Sound_Callback(UBYTE *buffer, unsigned int size);
|
Duplicate of #92 |
cmitu
added a commit
to cmitu/RetroPie-Setup
that referenced
this pull request
Jul 5, 2024
A buildfix patch [1] has been commited recently, but it introduced a regression [2]. Use the patch from [3] to replace the buildfix patch, since it has no side effects, until the libretro repository patches the issue. [1] libretro/libretro-atari800#92 [2] libretro/libretro-atari800#96, https://retropie.org.uk/forum/topic/35513/ [3] libretro/libretro-atari800#95
cmitu
referenced
this pull request
in pstef/libretro-atari800
Jul 15, 2024
twojstaryzdomu
pushed a commit
to twojstaryzdomu/RetroPie-Setup
that referenced
this pull request
Dec 15, 2024
A buildfix patch [1] has been commited recently, but it introduced a regression [2]. Use the patch from [3] to replace the buildfix patch, since it has no side effects, until the libretro repository patches the issue. [1] libretro/libretro-atari800#92 [2] libretro/libretro-atari800#96, https://retropie.org.uk/forum/topic/35513/ [3] libretro/libretro-atari800#95
twojstaryzdomu
pushed a commit
to twojstaryzdomu/RetroPie-Setup
that referenced
this pull request
Dec 15, 2024
A buildfix patch [1] has been commited recently, but it introduced a regression [2]. Use the patch from [3] to replace the buildfix patch, since it has no side effects, until the libretro repository patches the issue. [1] libretro/libretro-atari800#92 [2] libretro/libretro-atari800#96, https://retropie.org.uk/forum/topic/35513/ [3] libretro/libretro-atari800#95
twojstaryzdomu
pushed a commit
to twojstaryzdomu/RetroPie-Setup
that referenced
this pull request
Dec 15, 2024
A buildfix patch [1] has been commited recently, but it introduced a regression [2]. Use the patch from [3] to replace the buildfix patch, since it has no side effects, until the libretro repository patches the issue. [1] libretro/libretro-atari800#92 [2] libretro/libretro-atari800#96, https://retropie.org.uk/forum/topic/35513/ [3] libretro/libretro-atari800#95
twojstaryzdomu
pushed a commit
to twojstaryzdomu/RetroPie-Setup
that referenced
this pull request
Dec 15, 2024
A buildfix patch [1] has been commited recently, but it introduced a regression [2]. Use the patch from [3] to replace the buildfix patch, since it has no side effects, until the libretro repository patches the issue. [1] libretro/libretro-atari800#92 [2] libretro/libretro-atari800#96, https://retropie.org.uk/forum/topic/35513/ [3] libretro/libretro-atari800#95
twojstaryzdomu
pushed a commit
to twojstaryzdomu/RetroPie-Setup
that referenced
this pull request
Dec 15, 2024
A buildfix patch [1] has been commited recently, but it introduced a regression [2]. Use the patch from [3] to replace the buildfix patch, since it has no side effects, until the libretro repository patches the issue. [1] libretro/libretro-atari800#92 [2] libretro/libretro-atari800#96, https://retropie.org.uk/forum/topic/35513/ [3] libretro/libretro-atari800#95
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gcc-14,1 error
libretro/core-mapper.c: In function 'retro_sound_update': libretro/core-mapper.c:158:22: error: passing argument 1 of 'Sound_Callback' from incompatible pointer type [-Wincompatible-pointer-types]
158 | Sound_Callback(SNDBUF, 102422);
| ^~~~~~
| |
| short int *
In file included from ./atari800/src/platform.h:11,
from libretro/core-mapper.c:4:
./atari800/src/sound.h:75:28: note: expected 'unsigned char *' but argument is of type 'short int *'
75 | void Sound_Callback(UBYTE *buffer, unsigned int size);