-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix type to enable compilation #92
Conversation
Before this commit I got a compilation error about type mismatch between short int * and unsigned char *. To keep the buffer size intact, I double the number of elements since char is usually half the size of short int.
Sorry it took so long to merge this. |
How do we know it's this commit exactly that caused the regression? The report doesn't provide any details.
It's possible, but I would like to understand how that happened and what's the difference between the two proposed alternative changes that make the difference in practice before we choose one over the other. |
The report in the issue does not, but I've compiled the core with/without the changes in the PR after receiving the report in the forums and it's clear the commit is the cause. I'm assuming the issue has the same cause, given the seldom changes in the core repository and the timing of the report, so I chose to reference it instead of opening a new one. |
A buildfix patch [1] has been commited recently, but it introduced a regression [2]. Use the patch from [3] to replace the buildfix patch, since it has no side effects, until the libretro repository patches the issue. [1] libretro/libretro-atari800#92 [2] libretro/libretro-atari800#96, https://retropie.org.uk/forum/topic/35513/ [3] libretro/libretro-atari800#95
This reverts commit 8bfa3b8.
This reverts commit f72bc29.
…ternal01 (#101) * Update Makefile * Update Makefile * Change Paths Change paths from sd:/ to fs:/vol/external01 * Update Libco * Revert "Fix type to enable compilation (#92)" This reverts commit 8bfa3b8. * Revert "added ToadKing libco support that fixes emscripten build (#90)" This reverts commit 410d7bf. * Revert "use static_linking for emscripten platform (#89)" This reverts commit c50fb61. * Missed a sd: to fs:/vol/external01 change * Reapply "Fix type to enable compilation (#92)" This reverts commit f72bc29. * Reapply "use static_linking for emscripten platform (#89)" This reverts commit 25f0f5c. * Reapply "added ToadKing libco support that fixes emscripten build (#90)" This reverts commit ce1b4af. * found another sd:/ path that needed changing
A buildfix patch [1] has been commited recently, but it introduced a regression [2]. Use the patch from [3] to replace the buildfix patch, since it has no side effects, until the libretro repository patches the issue. [1] libretro/libretro-atari800#92 [2] libretro/libretro-atari800#96, https://retropie.org.uk/forum/topic/35513/ [3] libretro/libretro-atari800#95
A buildfix patch [1] has been commited recently, but it introduced a regression [2]. Use the patch from [3] to replace the buildfix patch, since it has no side effects, until the libretro repository patches the issue. [1] libretro/libretro-atari800#92 [2] libretro/libretro-atari800#96, https://retropie.org.uk/forum/topic/35513/ [3] libretro/libretro-atari800#95
A buildfix patch [1] has been commited recently, but it introduced a regression [2]. Use the patch from [3] to replace the buildfix patch, since it has no side effects, until the libretro repository patches the issue. [1] libretro/libretro-atari800#92 [2] libretro/libretro-atari800#96, https://retropie.org.uk/forum/topic/35513/ [3] libretro/libretro-atari800#95
A buildfix patch [1] has been commited recently, but it introduced a regression [2]. Use the patch from [3] to replace the buildfix patch, since it has no side effects, until the libretro repository patches the issue. [1] libretro/libretro-atari800#92 [2] libretro/libretro-atari800#96, https://retropie.org.uk/forum/topic/35513/ [3] libretro/libretro-atari800#95
A buildfix patch [1] has been commited recently, but it introduced a regression [2]. Use the patch from [3] to replace the buildfix patch, since it has no side effects, until the libretro repository patches the issue. [1] libretro/libretro-atari800#92 [2] libretro/libretro-atari800#96, https://retropie.org.uk/forum/topic/35513/ [3] libretro/libretro-atari800#95
Before this commit I got a compilation error about type mismatch between short int * and unsigned char *.
To keep the buffer size intact, I double the number of elements since char is usually half the size of short int.