Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type to enable compilation #92

Merged
merged 1 commit into from
May 18, 2024
Merged

Conversation

pstef
Copy link

@pstef pstef commented Mar 19, 2024

Before this commit I got a compilation error about type mismatch between short int * and unsigned char *.

To keep the buffer size intact, I double the number of elements since char is usually half the size of short int.

Before this commit I got a compilation error about type mismatch between
short int * and unsigned char *.

To keep the buffer size intact, I double the number of elements since
char is usually half the size of short int.
@LibretroAdmin
Copy link

Sorry it took so long to merge this.

@cmitu
Copy link

cmitu commented Jul 3, 2024

The changes have triggered a sound volume regression in the core, reported in #96 and also in the RetroPie forums.

The modifications here should be reverted and #95 should be applied instead, since it resolves the same issue and has no regression as far as audio volume is concerned.

@pstef
Copy link
Author

pstef commented Jul 3, 2024

The changes have triggered a sound volume regression in the core, reported in #96 and also in the RetroPie forums.

How do we know it's this commit exactly that caused the regression? The report doesn't provide any details.

The modifications here should be reverted and #95 should be applied instead, since it resolves the same issue and has no regression as far as audio volume is concerned.

It's possible, but I would like to understand how that happened and what's the difference between the two proposed alternative changes that make the difference in practice before we choose one over the other.

@cmitu
Copy link

cmitu commented Jul 4, 2024

How do we know it's this commit exactly that caused the regression? The report doesn't provide any details.

The report in the issue does not, but I've compiled the core with/without the changes in the PR after receiving the report in the forums and it's clear the commit is the cause. I'm assuming the issue has the same cause, given the seldom changes in the core repository and the timing of the report, so I chose to reference it instead of opening a new one.

cmitu added a commit to cmitu/RetroPie-Setup that referenced this pull request Jul 5, 2024
A buildfix patch [1] has been commited recently, but it introduced a regression [2].
Use the patch from [3] to replace the buildfix patch, since it has no side effects, until the libretro repository patches the issue.

[1] libretro/libretro-atari800#92
[2] libretro/libretro-atari800#96, https://retropie.org.uk/forum/topic/35513/
[3] libretro/libretro-atari800#95
Ploggy added a commit to Ploggy/libretro-atari800 that referenced this pull request Aug 1, 2024
Ploggy added a commit to Ploggy/libretro-atari800 that referenced this pull request Aug 1, 2024
LibretroAdmin pushed a commit that referenced this pull request Sep 6, 2024
…ternal01 (#101)

* Update Makefile

* Update Makefile

* Change Paths

Change paths from sd:/ to fs:/vol/external01

* Update Libco

* Revert "Fix type to enable compilation (#92)"

This reverts commit 8bfa3b8.

* Revert "added ToadKing libco support that fixes emscripten build (#90)"

This reverts commit 410d7bf.

* Revert "use static_linking for emscripten platform (#89)"

This reverts commit c50fb61.

* Missed a sd: to fs:/vol/external01 change

* Reapply "Fix type to enable compilation (#92)"

This reverts commit f72bc29.

* Reapply "use static_linking for emscripten platform (#89)"

This reverts commit 25f0f5c.

* Reapply "added ToadKing libco support that fixes emscripten build (#90)"

This reverts commit ce1b4af.

* found another sd:/ path that needed changing
twojstaryzdomu pushed a commit to twojstaryzdomu/RetroPie-Setup that referenced this pull request Dec 15, 2024
A buildfix patch [1] has been commited recently, but it introduced a regression [2].
Use the patch from [3] to replace the buildfix patch, since it has no side effects, until the libretro repository patches the issue.

[1] libretro/libretro-atari800#92
[2] libretro/libretro-atari800#96, https://retropie.org.uk/forum/topic/35513/
[3] libretro/libretro-atari800#95
twojstaryzdomu pushed a commit to twojstaryzdomu/RetroPie-Setup that referenced this pull request Dec 15, 2024
A buildfix patch [1] has been commited recently, but it introduced a regression [2].
Use the patch from [3] to replace the buildfix patch, since it has no side effects, until the libretro repository patches the issue.

[1] libretro/libretro-atari800#92
[2] libretro/libretro-atari800#96, https://retropie.org.uk/forum/topic/35513/
[3] libretro/libretro-atari800#95
twojstaryzdomu pushed a commit to twojstaryzdomu/RetroPie-Setup that referenced this pull request Dec 15, 2024
A buildfix patch [1] has been commited recently, but it introduced a regression [2].
Use the patch from [3] to replace the buildfix patch, since it has no side effects, until the libretro repository patches the issue.

[1] libretro/libretro-atari800#92
[2] libretro/libretro-atari800#96, https://retropie.org.uk/forum/topic/35513/
[3] libretro/libretro-atari800#95
twojstaryzdomu pushed a commit to twojstaryzdomu/RetroPie-Setup that referenced this pull request Dec 15, 2024
A buildfix patch [1] has been commited recently, but it introduced a regression [2].
Use the patch from [3] to replace the buildfix patch, since it has no side effects, until the libretro repository patches the issue.

[1] libretro/libretro-atari800#92
[2] libretro/libretro-atari800#96, https://retropie.org.uk/forum/topic/35513/
[3] libretro/libretro-atari800#95
twojstaryzdomu pushed a commit to twojstaryzdomu/RetroPie-Setup that referenced this pull request Dec 15, 2024
A buildfix patch [1] has been commited recently, but it introduced a regression [2].
Use the patch from [3] to replace the buildfix patch, since it has no side effects, until the libretro repository patches the issue.

[1] libretro/libretro-atari800#92
[2] libretro/libretro-atari800#96, https://retropie.org.uk/forum/topic/35513/
[3] libretro/libretro-atari800#95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants