-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LQ
calibration functions and PSD
propfuncs
#93
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #93 +/- ##
==========================================
- Coverage 41.50% 40.92% -0.58%
==========================================
Files 26 26
Lines 2000 2028 +28
==========================================
Hits 830 830
- Misses 1170 1198 +28 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there cases in which some function with lq
in its name does not use parse_cat = :lq
. Because if not, you might wanna remove the keyword argument pars_cat
from these functions and define them within the functions.
Some LQ functions seem like code duplication and could be combined with A/E functions, but this can be done later.
If I understand the question correctly you are asking if the |
Co-authored-by: Felix Hagemann <[email protected]>
…exp/LegendDataManagement.jl into lq-calibration-functions
The question was whether in a function with LQ in its name, the keyword argument is always LQ. |
This PR includes the
LQ
calibration functions andPSD
classifier defintions:LQ
calibration and cut definitionpsd_classifier
propfuncAttention: This PR inverts the
A/E
andLQ
cut logic: Anyclassifier_cut
parameter is nowtrue
if the event should be cut. This makes thePSD
part consisten with the rest of thejlevt
level.Note: This PR only works in combination with PR#14 in
LegendEventAnalysis