Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LQ calibration functions and PSD propfuncs #93

Merged
merged 6 commits into from
Mar 2, 2025

Conversation

theHenks
Copy link
Collaborator

@theHenks theHenks commented Mar 2, 2025

This PR includes the LQ calibration functions and PSD classifier defintions:

  • LQ calibration and cut definition
  • psd_classifier propfunc

Attention: This PR inverts the A/E and LQ cut logic: Any classifier_cut parameter is now true if the event should be cut. This makes the PSD part consisten with the rest of the jlevt level.

Note: This PR only works in combination with PR#14 in LegendEventAnalysis

@theHenks theHenks requested a review from fhagemann March 2, 2025 01:51
@theHenks theHenks self-assigned this Mar 2, 2025
@theHenks theHenks added enhancement New feature or request bug Something isn't working labels Mar 2, 2025
Copy link

codecov bot commented Mar 2, 2025

Codecov Report

Attention: Patch coverage is 0% with 36 lines in your changes missing coverage. Please review.

Project coverage is 40.92%. Comparing base (31b177f) to head (607f6a8).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
src/calibration_functions.jl 0.00% 36 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #93      +/-   ##
==========================================
- Coverage   41.50%   40.92%   -0.58%     
==========================================
  Files          26       26              
  Lines        2000     2028      +28     
==========================================
  Hits          830      830              
- Misses       1170     1198      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@fhagemann fhagemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there cases in which some function with lq in its name does not use parse_cat = :lq. Because if not, you might wanna remove the keyword argument pars_cat from these functions and define them within the functions.

Some LQ functions seem like code duplication and could be combined with A/E functions, but this can be done later.

@theHenks
Copy link
Collaborator Author

theHenks commented Mar 2, 2025

Are there cases in which some function with lq in its name does not use parse_cat = :lq. Because if not, you might wanna remove the keyword argument pars_cat from these functions and define them within the functions.

Some LQ functions seem like code duplication and could be combined with A/E functions, but this can be done later.

If I understand the question correctly you are asking if the kwarg is always used. I checked all and yes, they are everywhere were I put them in.

@theHenks theHenks merged commit 33f60ef into main Mar 2, 2025
9 of 11 checks passed
@theHenks theHenks deleted the lq-calibration-functions branch March 2, 2025 12:41
@fhagemann
Copy link
Contributor

If I understand the question correctly you are asking if the kwarg is always used. I checked all and yes, they are everywhere were I put them in.

The question was whether in a function with LQ in its name, the keyword argument is always LQ.
But this can be dealt with once we remove code duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants