Skip to content

Conversation

@theHenks
Copy link
Collaborator

@theHenks theHenks commented Mar 2, 2025

This PR includes the LQ in the jlevt level:

  • LQ calibration and cut definition, including new classifier per detector
  • New psd_classifier definition based on a user-defined cut combination
  • New global is_valid_psd event tag for easier event selection based on valid psd_classifier of all triggered channels

Note: This PR only works in combination with PR#93 in LegendDataManagement

@theHenks theHenks requested a review from fhagemann March 2, 2025 01:46
@theHenks theHenks self-assigned this Mar 2, 2025
@theHenks theHenks added the enhancement New feature or request label Mar 2, 2025
@codecov
Copy link

codecov bot commented Mar 2, 2025

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 7.81%. Comparing base (8de1790) to head (5e2bee1).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/calibrate_geds.jl 0.00% 9 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main     #14      +/-   ##
========================================
- Coverage   7.94%   7.81%   -0.14%     
========================================
  Files          6       6              
  Lines        239     243       +4     
========================================
  Hits          19      19              
- Misses       220     224       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@theHenks theHenks merged commit 0535a84 into main Mar 2, 2025
8 of 10 checks passed
@theHenks theHenks deleted the hpge-lq-cut branch March 2, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants