Use target-specific include dirs #464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allnes
reviewed
Jun 23, 2025
CMakeLists.txt
Outdated
| @@ -47,9 +47,6 @@ include(cmake/gtest.cmake) | |||
| ############################## Headers ############################## | |||
|
|
|||
| message( STATUS "PPC step: Setup headers" ) | |||
There was a problem hiding this comment.
Please remove all info about headers here
aobolensk
force-pushed
the
codex/replace-include_directories-with-target_include_directories
branch
from
19c9bbb to
73078d3
Compare
aobolensk
force-pushed
the
codex/replace-include_directories-with-target_include_directories
branch
from
73078d3 to
189a1c0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #464 +/- ##
=======================================
Coverage 91.73% 91.73%
=======================================
Files 11 11
Lines 363 363
Branches 131 131
=======================================
Hits 333 333
Misses 10 10
Partials 20 20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Coverage report is available for download |
|
Coverage report is available for download |
allnes
approved these changes
Jun 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop global include_directories from CMakeLists.txt